Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core) 'enter' behavior on android custom node views #4153

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

C-Hess
Copy link
Contributor

@C-Hess C-Hess commented Jun 24, 2023

Please describe your changes

Applied the same fix on iOS to Android, as Android appears to be having the same issue on enter

Credit to @slapbox for finding the link to the existing fix made to iOS for the same issue.

How did you accomplish your changes

N/A

How have you tested your changes

Tested that both the React and Vue custom node view (w/content) examples worked on an Android device (Samsung Galaxy S22; Chrome) and verified that hitting enter at the beginning, middle, or end of the custom node view works as expected

Remarks

No tests were written. Doesn't seem reasonable/easy to test with cypress

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

fixes #2534

@netlify
Copy link

netlify bot commented Jun 24, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 2a5dc82
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/649780da5df8d70008516de6
😎 Deploy Preview https://deploy-preview-4153--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll include it in the next RC release so people can test this before it hits stable!

@bdbch bdbch merged commit b7dc5d4 into ueberdosis:develop Jun 25, 2023
14 checks passed
@Nantris
Copy link
Contributor

Nantris commented Jul 1, 2023

Thanks for fixing this @C-Hess; so glad that was the only problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android, React/Vue] Pressing "Enter" in an interactive node view creates non-deletable nodes
3 participants