Update markInputRule.ts #4162
Merged
Update markInputRule.ts #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivial change - the markEnd variable was assigned outside the block and then reassigned within the block without ever using the initial value. Using const assignment just above the first use of the variable improves readability.
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdbch
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Thanks for the PR. Looks good to me. @svenadlung what about you?
|
@svenadlung I'll merge this for now as this should not break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
trivial change - the
markEndvariable was assigned outside theifblock and then reassigned within the block without ever using the initial value. Using const assignment just above the first use of the variable improves readability.How did you accomplish your changes
search through the file for any other occurences of
markEnd- there are noneHow have you tested your changes
N/A trivial change to help people trying to read and understand what the code and variables are achieving
How can we verify your changes
look at the tiny changes to the file, verify there are no other occurences of markEnd with a simple text search of the file
Remarks
This will make no difference to the function, but improves readability & most style guides do not like useless assignment or assigning outside the block a variable is used and prefer const over let when never reassigning etc.
Checklist