-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix List issues & add support for Mod keys #4210
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
When will this version be released? I would love to see my backspace work asap 🙂❤ |
@svenadlung could you take a look? |
I was looking through these changes and I'm curious what the changes to the |
If I remember correctly the issue occured when something was cut and moved after the cut content. Since the mapping wasn't respected beforehand, the insert position was invalid. I could check again if I find some time what it was about exactly. |
I also noticed the logic in these Backspace handler lines lacks corresponding logic in the Delete handler: tiptap/packages/core/src/helpers/listHelpers/handleBackspace.ts Lines 20 to 42 in 2a11d39
|
Thanks for the reply @bdbch! I was curious looking at it because it seems similar to the weird mapping misbehavior in #4283 Edit: Seems pretty likely to me actually since all the mapping issues I hit were related to chained commands on lists specifically. |
Please describe your changes
This PR fixes various issues with lists (for example when the cursor is placed right behind a list and backspace is pressed).
It also moves all list helpers into core so they can be used by taskLists too.
Checklist
Related Issues
closes #3128
closes #2747