[Bug]: HTML output of Table is missing colgroup element #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdbch
requested changes
Aug 4, 2023
bdbch
approved these changes
Aug 11, 2023
|
@bdbch any change to get this merged any time soon? |
iowxy
reviewed
Nov 28, 2023
| mergeAttributes(this.options.HTMLAttributes, HTMLAttributes, { | ||
| style: tableWidth | ||
| ? `width: ${tableWidth}` | ||
| : `minWidth: ${tableMinWidth}`, |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4280
Please describe your changes
Added createColGroup function to generate colGroup based on child nodes (imitates
updateColumnswhich is used for editor TableView.How did you accomplish your changes
renderHTMLis callingupdateColumnsto get generatedcolgroupelement,tableWidthandtableMinWidthvalues.How have you tested your changes
Updated react and vue e2e tests to assert that there is
colgroup-element.How can we verify your changes
[add a detailed description of how we can verify your changes here]
Remarks
[add any additional remarks here]
Checklist
Related issues
#721