feat(typography): allow overrides of inputRule outputs #4287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR adds the option to replace the output of the inputRules used for the Typography extension.
With this PR users can now do something like this to add overrides to specific characters:
How did you accomplish your changes
Instead of just passing static strings, I used callback functions that will return a new inputRule with said override (if it exists)
How have you tested your changes
I added a local test for my change which worked + I tried out the inputRule override manually.
How can we verify your changes
Check out this PR or go to the deployed demo and try out to replace
->
to=====>
on the TypographyWithOverrides demo page.Remarks
/
Checklist
Related issues
closes #2598