chore(lists): move list keymap to extra extension #4290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Because our custom keymap handling could potentially break when Prosemirror gets updated we decided to not have any custom fixes for that in our core but move it to an extra extension that can be loaded if the default keymap of Prosemirror is not sufficient.
This way we can also avoid breaking the core editing behaviour because of potential bugs in those custom fixes.
How did you accomplish your changes
Moved all of the keymap handling into it's own extension
How have you tested your changes
I created local demos - if you want to test it:
ListKeymap
extensionRemarks
This is crucical to finally release a new stable version (2.1.0) as I don't want those keymaps in the core in 2.1.0
Checklist