Core: Fix classes being duplicated on mergeAttributes function #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdbch
added
Type: Bug
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
svenadlung
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Before this change, the class attribute on
HTMLAttributeswould be duplicated inside themergeAttributesfunction, because there was no check if a class already exists on theHTMLAttributesstring (coming from defaultOptions and inputOptions).This PR fixes this.
How did you accomplish your changes
Added a check if the className is already included inside the class attribute.
How have you tested your changes
Tested locally in the link demo with normal class and BEM class style
How can we verify your changes
See above
Checklist
Related issues
fixes #4282