Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade y-prosemirror #4353

Closed
wants to merge 2 commits into from

Conversation

nikgraf
Copy link
Contributor

@nikgraf nikgraf commented Aug 19, 2023

Please describe your changes

  • Upgrade to the latest y-prosemirror version
  • Make sure it's compatible with y-prosemirror 1 and people can choose their own version

How did you accomplish your changes

Update the peerDependencies and devDependencies

How have you tested your changes

Not yet

How can we verify your changes

Make sure all collaboration demos are working as expected.

Remarks

I guess there was a reason why it was locked to a specific y-prosemirror, but couldn't find any remarks or issues.

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 666c6f8
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/64e1992c9644250008d47843
😎 Deploy Preview https://deploy-preview-4353--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch
Copy link
Contributor

bdbch commented Aug 19, 2023

Thanks @nikgraf – I think we'd have to test this more extensively to see if it introduces bugs or breaking changes.

@nikgraf
Copy link
Contributor Author

nikgraf commented Aug 20, 2023

@bdbch makes sense, do you have some protocol on how to test such changes? I could look into it

@janthurau
Copy link
Collaborator

Thanks for this! I'll merge this as #4638, as I had to fix a few tests which were broken on our side first.

@janthurau janthurau closed this Nov 17, 2023
@nikgraf nikgraf deleted the upgrade-y-prosemirror branch November 17, 2023 10:06
@nikgraf
Copy link
Contributor Author

nikgraf commented Nov 17, 2023

awesome, glad to see movement here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants