fix: add missing attributes in extension-link #4429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite
rel
andclass
already being defined as an attribute inaddAttributes()
, the interface was missing these two particular attributes so it wasn't accessible when using TypeScript without workarounds.Please describe your changes / How did you accomplish your changes
I added the missing attributes to the interface
How have you tested your changes
Full disclosure, I haven't tested it yet. This is a quick PR that I made from GitHub's web editor so that I don't forget to test it later and submit a fix properly.
How can we verify your changes
Open a typescript file and try to add a link through
Remarks
Checklist
Related issues