-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fix insertContentAt keeping new lines in html content #4465
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@svenadlung can you take a look too? self reviewing right now. |
Update: Found some more issues I'd have to take a look into. |
Okay - ready. @svenadlung if you have some time a review would be great. |
Ping @svenadlung |
@bdbch Sorry for the delay. At the first moment it feels to me like something could break of the change. Please give me some more time for a review. Probably until the end of next week due to public holidays. |
We're also facing this issue, do we have any updates? @svenadlung |
cf26f02
to
ca6546f
Compare
Any progress here? |
@svenadlung should we include this in our next release or should we postpone it for a later release? |
This fix breaks |
working on a fix @murisceman |
PR is here: #4767 |
Please describe your changes
This PR fixes the issue described in #2720 which was caused by keeping new lines in string content and using the DOMParser which will add breaks for new lines too.
How did you accomplish your changes
I strip out
\n
content from the content string so new lines are interpretet by the DOMParser only.How have you tested your changes
I created a demo where this can be tested. (See here)
How can we verify your changes
Test in the demo above
Checklist
Related issues