Bump minor version of zeed-dom to include html parser bugfix #4524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
estrattonbailey
force-pushed
the
update-zeed-dom
branch
from
8cb3356
to
1d158e4
Compare
|
Hey @svenadlung just wanted to bump this one too. Let me know if there's an issue with the minor version bump, I'm sure we could help zeed-dom release a patch to v9 as well. |
janthurau
force-pushed
the
update-zeed-dom
branch
from
1d158e4
to
3383db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Noticed a bug in
zeed-dom, a downstream dep of Tiptap. I made a PR and the maintainer has published a new version.I didn't notice up front was that it's a minor version ahead of what Tiptap relies on. Using
yarnresolutions, we've tested our app internally with my fork, and I've run the tests here, and all appears to be fine. But I'll leave it up to the maintainers here to confirm that all is well ✌️How did you accomplish your changes
Debugged with some logs in Tiptap, isolated to
parseHTML, replicated inzeed-domand fixed.How have you tested your changes
We opted to resolve the dep to my branch for now (see PR here). I also ran any tests that seemed related in Cypress.
How can we verify your changes
Unsure what else you'd like to do, but the e2e suite is extensive by the looks of it. Happy to help!
Remarks
If y'all don't want to bump the minor version, we could probably make the same fix in
0.9.*if we need to.Checklist