Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extension-collaboration & extension-collaboration-cursor package.json #4626

Closed
wants to merge 2 commits into from

Conversation

websiddu
Copy link

@websiddu websiddu commented Nov 11, 2023

Please describe your changes

Updating the peer dependencies to the latest version of y-prosemirror so it won't show an error.

Currently when using @tiptap/extension-collaboration and with latest y-prosemirror will show a warning.

warning " > @tiptap/extension-collaboration@2.2.0-rc.4" has incorrect peer dependency "y-prosemirror@1.0.20".
warning " > @tiptap/extension-collaboration-cursor@2.2.0-rc.4" has incorrect peer dependency "y-prosemirror@1.0.20".

How did you accomplish your changes

Updating the package.json.

How have you tested your changes

Its safe to update as I tested with latest version.

How can we verify your changes

Verified in my own app with the latest version for y-prosemirror — ^1.2.1

Checklist

  • [ x] The changes are not breaking the editor
  • [ x] Added tests where possible
  • [ x] Fixed linting issues
  • [ x] Followed the guidelines

Updating the peer dependencies to the latest version of y-prosemirror so it won't show an error. 

Currently when using @tiptap/extension-collaboration and with latest `y-prosemirror` will show a warning.

Its safe to update as I tested with latest version. 

```
warning " > @tiptap/extension-collaboration@2.2.0-rc.4" has incorrect peer dependency "y-prosemirror@1.0.20".
warning " > @tiptap/extension-collaboration-cursor@2.2.0-rc.4" has incorrect peer dependency "y-prosemirror@1.0.20".
```
Copy link

netlify bot commented Nov 11, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit e0424f2
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/654fb67617c8020008314b5f
😎 Deploy Preview https://deploy-preview-4626--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@websiddu websiddu changed the title Update package.json Update extension-collaboration & extension-collaboration-cursor package.json Nov 11, 2023
@janthurau
Copy link
Collaborator

Thanks for this! I'll merge this as #4638, as I had to fix a few tests which were broken on our side first.

@janthurau janthurau closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants