feat(react): add useEditorForImmediateRender hook #4858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
C-Hess
reviewed
May 29, 2024
| // In case you want to render the editor immediately, you can use this hook. | ||
| // Caution: Does not work with SSR. | ||
| export const useEditorForImmediateRender = (options: Partial<EditorOptions> = {}, deps: DependencyList = []): Editor => { | ||
| const editor = useEditorBase(options, deps, true) as Editor |
There was a problem hiding this comment.
This a nice way to abstract the base editor logic unlike my PR. However, I highly recommend using memo instead of ref as the lifecycle becomes a lot more simpler (especially with editor cleanup)
|
Resolved with: #5161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be added …
Please describe your changes
[add a description of your changes here]
How did you accomplish your changes
[add a detailed description of how you accomplished your changes here]
How have you tested your changes
[add a detailed description of how you tested your changes here]
How can we verify your changes
[add a detailed description of how we can verify your changes here]
Remarks
[add any additional remarks here]
Checklist
Related issues
[add a link to the related issues here]