fix: #5851 - While setting content directly while using CharacterCount with limit is not obeyed

[gethari]

Fixes #5851

2024-11-22.at.16.17.40.-.Tan.Cephalopod.mp4

[netlify]

✅ Deploy Preview for tiptap-embed ready!

Name	Link
🔨 Latest commit	bbc4743
🔍 Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/674197990f35f00008a8fa1d
😎 Deploy Preview	https://deploy-preview-5862--tiptap-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[gethari]

@nperez0111 can you please let me know your thoughts / review this please ?

[nperez0111]

This looks good! Thanks for the contribution @gethari

[gethari]

Hey @nperez0111 , I think I might have caused a side effect because of this, when the charLimit is set, whenever we try to call setContent , its not getting reflected 😢

[nperez0111]

That doesn't sound right to me, can you reproduce in a sandbox & prove that it this.

Most likely, you are running into something a lot of people do, trying to put html in setContent and thinking it will work exactly as you input it. As a test, could you try doing insertContent which takes a different codepath than setContent

[gethari]

@nperez0111 please find the Sanbox,

The size of the content inside setContent is 321, so if we set the limit >= the size, this works, but when we use limit of 300, the content is not getting overridden, I guess previously it was just setting the content all-together without obeying the limit, after my appendTransaction, i think this is getting skipped

[nperez0111]

Yea, not sure what is going on here & I don't have time to fix it. Could you open a new issue? What is strange to me is that it feels like appendTransaction should always run so I'm not sure that we need to run the modification in the filter transaction anymore, & just let it be in the appendTransaction instead