Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace injection tokens with symbols and use provider module #488

Merged
merged 5 commits into from
Jul 21, 2024
Merged

refactor: replace injection tokens with symbols and use provider module #488

merged 5 commits into from
Jul 21, 2024

Conversation

ueokande
Copy link
Owner

@ueokande ueokande commented Jul 21, 2024 •
edited
Loading

This PR includes two concepts of refactoring.

  • Migrate tokens at @inject() of inversify with the Symbol instead of using a string. Using symbols is more robust than string.
  • Use inversify-binding-decorators to bind class instead of binding manually.

@ueokande ueokande changed the title chore: Inject by symbols refactor: replace injection tokens with symbols and use provider module Jul 21, 2024
@ueokande ueokande marked this pull request as ready for review July 21, 2024 09:19
@ueokande ueokande merged commit 433affd into master Jul 21, 2024
2 checks passed
@ueokande ueokande deleted the inject-by-symbols branch July 21, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ueokande