Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debugging messaging #82

Merged
merged 2 commits into from
Mar 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@
"description": "vimmatic",
"version": "0.0.1",
"scripts": {
"start": "nodemon --watch ./src --ext js,jsx,ts,tsx,css,html,json script/build",
"start": "NODE_ENV=development nodemon --watch ./src --ext js,jsx,ts,tsx,css,html,json script/build",
"clean": "rm -rf ./dist",
"prebuild": "yarn clean",
"build": "script/build",
"prepackage": "yarn build",
"package": "yarn build && script/package",
"lint": "eslint --ext .ts,.tsx .",
"lint:fix": "eslint --ext .ts,.tsx . --fix",
Expand Down
3 changes: 3 additions & 0 deletions script/build
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ const targets = {

const buildScripts = async (browser) => {
await build({
define: {
'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV),
},
entryPoints: {
console: "src/console/index.tsx",
content: "src/content/index.ts",
Expand Down
4 changes: 2 additions & 2 deletions src/background/Application.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { injectable, inject } from "inversify";
import BackgroundMessageListener from "./infrastructures/BackgroundMessageListener";
import FindPortListener from "./infrastructures/FindPortListener";
import BackgroundMessageListener from "./messaging/BackgroundMessageListener";
import FindPortListener from "./messaging/FindPortListener";
import VersionUseCase from "./usecases/VersionUseCase";
import FindRepositoryImpl from "./repositories/FindRepository";
import ReadyFrameRepository from "./repositories/ReadyFrameRepository";
Expand Down
5 changes: 5 additions & 0 deletions src/background/clients/ConsoleMessageSender.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ type ConsoleMessageSender = Sender<Schema>;

export const newSender = (tabId: number, frameId?: number) => {
const sender = new Sender<Schema>((type: Key, args: Request) => {
if (process.env.NODE_ENV === "development") {
const style = "background-color: green; color: white; padding: 4px;";
console.debug("%cSEND%c %s %o", style, "", type, args);
}

const msg = { type, args: args ?? {} };
return chrome.tabs.sendMessage(tabId, msg, { frameId });
});
Expand Down
6 changes: 6 additions & 0 deletions src/background/clients/ContentMessageSender.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ type ContentMessageSender = Sender<Schema>;

export const newSender = (tabId: number, frameId?: number) => {
const sender = new Sender<Schema>((type: Key, args: Request) => {
if (process.env.NODE_ENV === "development") {
const style = "background-color: green; color: white; padding: 4px;";
const reset = "background-color: unset; color: unset; padding: unset;";
console.debug("%cSEND%c %s %o", style, reset, type, args);
}

const msg = { type, args: args ?? {} };
return chrome.tabs.sendMessage(tabId, msg, { frameId });
});
Expand Down
2 changes: 1 addition & 1 deletion src/background/controllers/CommandController.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { injectable, inject } from "inversify";
import { Completions } from "../../shared/Completions";
import CommandUseCase from "../usecases/CommandUseCase";
import RequestContext from "../infrastructures/RequestContext";
import RequestContext from "../messaging/RequestContext";

@injectable()
export default class CommandController {
Expand Down
2 changes: 1 addition & 1 deletion src/background/controllers/ConsoleController.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { injectable, inject } from "inversify";
import ConsoleUseCase from "../usecases/ConsoleUseCase";
import RequestContext from "../infrastructures/RequestContext";
import RequestContext from "../messaging/RequestContext";

@injectable()
export default class ConsoleController {
Expand Down
2 changes: 1 addition & 1 deletion src/background/controllers/FindController.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { injectable, inject } from "inversify";
import StartFindUseCase from "../usecases/StartFindUseCase";
import RequestContext from "../infrastructures/RequestContext";
import RequestContext from "../messaging/RequestContext";

@injectable()
export default class FindController {
Expand Down
2 changes: 1 addition & 1 deletion src/background/controllers/KeyController.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { injectable, inject } from "inversify";
import RequestContext from "../infrastructures/RequestContext";
import RequestContext from "../messaging/RequestContext";
import MarkJumpUseCase from "../usecases/MarkJumpUseCase";
import MarkSetUseCase from "../usecases/MarkSetUseCase";
import MarkModeUseCase from "../usecases/MarkModeUseCase";
Expand Down
2 changes: 1 addition & 1 deletion src/background/controllers/LinkController.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { injectable, inject } from "inversify";
import LinkUseCase from "../usecases/LinkUseCase";
import RequestContext from "../infrastructures/RequestContext";
import RequestContext from "../messaging/RequestContext";

@injectable()
export default class LinkController {
Expand Down
2 changes: 1 addition & 1 deletion src/background/controllers/OperationController.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { inject, injectable } from "inversify";
import OperationUseCase from "../usecases/OperationUseCase";
import RequestContext from "../infrastructures/RequestContext";
import RequestContext from "../messaging/RequestContext";

@injectable()
export default class OperationController {
Expand Down
2 changes: 1 addition & 1 deletion src/background/controllers/SettingsController.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { injectable, inject } from "inversify";
import SettingsUseCase from "../usecases/SettingsUseCase";
import RequestContext from "../infrastructures/RequestContext";
import RequestContext from "../messaging/RequestContext";

@injectable()
export default class SettingsController {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ export default class BackgroundMessageListener {
return;
}

if (process.env.NODE_ENV === "development") {
const style = "background-color: purple; color: white; padding: 4px;";
console.debug("%cRECEIVE%c %s %o", style, "", type, args);
}
const ret = this.receiver.receive(ctx, type, args);
Promise.resolve(ret)
.then(sendResponse)
Expand Down
2 changes: 1 addition & 1 deletion src/background/repositories/AddonEnabledRepository.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { injectable } from "inversify";
import MemoryStorage from "../infrastructures/MemoryStorage";
import MemoryStorage from "../db/MemoryStorage";

export default interface AddonEnabledRepository {
enable(): void;
Expand Down
2 changes: 1 addition & 1 deletion src/background/repositories/FindRepository.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { injectable } from "inversify";
import MemoryStorage from "../infrastructures/MemoryStorage";
import MemoryStorage from "../db/MemoryStorage";

export type FindState = {
keyword: string;
Expand Down
2 changes: 1 addition & 1 deletion src/background/repositories/FollowRepository.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { injectable } from "inversify";
import MemoryStorage from "../infrastructures/MemoryStorage";
import MemoryStorage from "../db/MemoryStorage";

export default interface FollowRepository {
startFollowMode(
Expand Down
2 changes: 1 addition & 1 deletion src/background/repositories/MarkModeRepository.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { injectable } from "inversify";
import MemoryStorage from "../infrastructures/MemoryStorage";
import MemoryStorage from "../db/MemoryStorage";

export default interface MarkModeRepository {
enableSetMode(): void;
Expand Down
2 changes: 1 addition & 1 deletion src/background/repositories/MarkRepository.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { injectable } from "inversify";
import MemoryStorage from "../infrastructures/MemoryStorage";
import MemoryStorage from "../db/MemoryStorage";
import GlobalMark from "../domains/GlobalMark";
import LocalMark from "../domains/LocalMark";

Expand Down
2 changes: 1 addition & 1 deletion src/background/repositories/ReadyFrameRepository.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { injectable } from "inversify";
import MemoryStorage from "../infrastructures/MemoryStorage";
import MemoryStorage from "../db/MemoryStorage";

type State = { [tabId: number]: { [frameId: number]: number } };

Expand Down
2 changes: 1 addition & 1 deletion src/background/repositories/RepeatRepository.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { injectable } from "inversify";
import MemoryStorage from "../infrastructures/MemoryStorage";
import MemoryStorage from "../db/MemoryStorage";
import { Operation } from "../../shared/operations2";

export default interface RepeatRepository {
Expand Down
2 changes: 1 addition & 1 deletion src/background/settings/SettingsRepository.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { injectable, inject } from "inversify";
import MemoryStorage from "../infrastructures/MemoryStorage";
import MemoryStorage from "../db/MemoryStorage";
import { defaultSettings, serialize, deserialize } from "../../settings";
import Settings from "../../shared/Settings";
import { SerializedSettings } from "../../settings/schema";
Expand Down
2 changes: 1 addition & 1 deletion src/background/usecases/CommandUseCase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Completions } from "../../shared/Completions";
import { injectable, inject } from "inversify";
import CommandRegistry from "../command/CommandRegistry";
import { parseCommand, onCommandInputting } from "./parser";
import RequestContext from "../infrastructures/RequestContext";
import RequestContext from "../messaging/RequestContext";
import { CommandContext } from "../command/Command";

@injectable()
Expand Down
2 changes: 1 addition & 1 deletion src/background/usecases/OperationUseCase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { inject, injectable } from "inversify";
import type { Props, OperatorContext } from "../operators/Operator";
import OperatorRegistory from "../operators/OperatorRegistory";
import RepeatRepository from "../repositories/RepeatRepository";
import RequestContext from "../infrastructures/RequestContext";
import RequestContext from "../messaging/RequestContext";

@injectable()
export default class OperationUseCase {
Expand Down
5 changes: 5 additions & 0 deletions src/content/client/BackgroundMessageSender.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ type BackgroundMessageSender = Sender<Schema>;

export const newSender = () => {
const sender = new Sender<Schema>((type: Key, args: Request) => {
if (process.env.NODE_ENV === "development") {
const style = "background-color: green; color: white; padding: 4px;";
console.debug("%cSEND%c %s %o", style, "", type, args);
}

return chrome.runtime.sendMessage({
type,
args: args ?? {},
Expand Down
5 changes: 5 additions & 0 deletions src/content/messaging/ContentMessageListener.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,11 @@ export default class ContentMessageListener {
return;
}

if (process.env.NODE_ENV === "development") {
const style = "background-color: purple; color: white; padding: 4px;";
console.debug("%cRECEIVE%c %s %o", style, "", type, args);
}

const ret = this.receiver.receive(type, args);
Promise.resolve(ret)
.then(sendResponse)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import MemoryStorage from "../../../src/background/infrastructures/MemoryStorage";
import MemoryStorage from "../../../src/background/db/MemoryStorage";

describe("MemoryStorage", () => {
it("stores string value", () => {
Expand Down
2 changes: 1 addition & 1 deletion test/background/mock/MockConsoleClient.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import ConsoleClient from "../../../src/background/infrastructures/ConsoleClient";
import ConsoleClient from "../../../src/background/clients/ConsoleClient";

export default class MockConsoleClient implements ConsoleClient {
hide(_tabId: number): Promise<any> {
Expand Down