Skip to content

Commit

Permalink
[SPARK-45477][INFRA] Use matrix.java/inputs.java to replace the har…
Browse files Browse the repository at this point in the history
…dcoded Java version in `test results/unit tests log` naming

### What changes were proposed in this pull request?
There are some places in `build_and_test.yml` where the Java version part is hardcoded to 8 when naming `test results/unit tests log`, this pr changes them to use `matrix.java/inputs.java`.

### Why are the changes needed?
The actual Java version should be used to name the `test results/unit tests log`.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Monitor GA, check if the `test results/unit tests log` has used the actual Java version for naming.

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#43305 from LuciferYang/ga-test-log-name.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
LuciferYang authored and dongjoon-hyun committed Oct 10, 2023
1 parent 6373f19 commit c47a920
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -465,13 +465,13 @@ jobs:
if: always()
uses: actions/upload-artifact@v3
with:
name: test-results-${{ matrix.modules }}--8-${{ inputs.hadoop }}-hive2.3
name: test-results-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: unit-tests-log-${{ matrix.modules }}--8-${{ inputs.hadoop }}-hive2.3
name: unit-tests-log-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3
path: "**/target/unit-tests.log"

sparkr:
Expand Down Expand Up @@ -550,7 +550,7 @@ jobs:
if: always()
uses: actions/upload-artifact@v3
with:
name: test-results-sparkr--8-${{ inputs.hadoop }}-hive2.3
name: test-results-sparkr--${{ inputs.java }}-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"

breaking-changes-buf:
Expand Down Expand Up @@ -916,13 +916,13 @@ jobs:
if: always()
uses: actions/upload-artifact@v3
with:
name: test-results-tpcds--8-${{ inputs.hadoop }}-hive2.3
name: test-results-tpcds--${{ inputs.java }}-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: unit-tests-log-tpcds--8-${{ inputs.hadoop }}-hive2.3
name: unit-tests-log-tpcds--${{ inputs.java }}-${{ inputs.hadoop }}-hive2.3
path: "**/target/unit-tests.log"

docker-integration-tests:
Expand Down Expand Up @@ -983,13 +983,13 @@ jobs:
if: always()
uses: actions/upload-artifact@v3
with:
name: test-results-docker-integration--8-${{ inputs.hadoop }}-hive2.3
name: test-results-docker-integration--${{ inputs.java }}-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: unit-tests-log-docker-integration--8-${{ inputs.hadoop }}-hive2.3
name: unit-tests-log-docker-integration--${{ inputs.java }}-${{ inputs.hadoop }}-hive2.3
path: "**/target/unit-tests.log"

k8s-integration-tests:
Expand Down

0 comments on commit c47a920

Please sign in to comment.