Skip to content

Commit

Permalink
[SPARK-45037][INFRA] Upload unit tests log files for timeouted cancel
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

We currently upload ut logs on failures, while if there is a canceled state, there could be problems, too. We need those logs for bug hunting.

### Why are the changes needed?

There may be evidence of a timeout cancellation in the logs.

reference: https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

by github actions

### Was this patch authored or co-authored using generative AI tooling?

no

Closes apache#42756 from yaooqinn/SPARK-45037.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
yaooqinn authored and dongjoon-hyun committed Sep 1, 2023
1 parent 8c27de6 commit e86849a
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ jobs:
name: test-results-${{ matrix.modules }}-${{ matrix.comment }}-${{ matrix.java }}-${{ matrix.hadoop }}-${{ matrix.hive }}
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
if: failure()
if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: unit-tests-log-${{ matrix.modules }}-${{ matrix.comment }}-${{ matrix.java }}-${{ matrix.hadoop }}-${{ matrix.hive }}
Expand Down Expand Up @@ -470,7 +470,7 @@ jobs:
name: test-results-${{ matrix.modules }}--8-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
if: failure()
if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: unit-tests-log-${{ matrix.modules }}--8-${{ inputs.hadoop }}-hive2.3
Expand Down Expand Up @@ -961,7 +961,7 @@ jobs:
name: test-results-tpcds--8-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
if: failure()
if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: unit-tests-log-tpcds--8-${{ inputs.hadoop }}-hive2.3
Expand Down Expand Up @@ -1028,7 +1028,7 @@ jobs:
name: test-results-docker-integration--8-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
if: failure()
if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: unit-tests-log-docker-integration--8-${{ inputs.hadoop }}-hive2.3
Expand Down Expand Up @@ -1103,7 +1103,7 @@ jobs:
eval $(minikube docker-env)
build/sbt -Psparkr -Pkubernetes -Pvolcano -Pkubernetes-integration-tests -Dspark.kubernetes.test.driverRequestCores=0.5 -Dspark.kubernetes.test.executorRequestCores=0.2 -Dspark.kubernetes.test.volcanoMaxConcurrencyJobNum=1 -Dtest.exclude.tags=local "kubernetes-integration-tests/test"
- name: Upload Spark on K8S integration tests log files
if: failure()
if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: spark-on-kubernetes-it-log
Expand Down

0 comments on commit e86849a

Please sign in to comment.