Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision stack implementation #1185

Merged
merged 15 commits into from
Apr 22, 2024
Merged

Vision stack implementation #1185

merged 15 commits into from
Apr 22, 2024

Conversation

DaniParr
Copy link
Contributor

@DaniParr DaniParr commented Apr 8, 2024

Description

Added the vision_stack package that will serve as the base for our vision pipeline for everything cv and ml!

Screenshot or Video

Related Issues

- Closes #XXX

Testing

About This PR

  • I have updated documentation related to this change so that future members are aware of the changes I've made.

@uf-mil-bot
Copy link
Collaborator

uf-mil-bot commented Apr 10, 2024

Hola, your friendly InvestiGator bot here with another message!

Because this PR was closed/merged, I'm going to remove the docs preview for now.

Have a great day! Go gators! 🐊

Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one small question.

SIZE = (960, 608)
self.vs = VisionStack(
layers=[
ResizeLayer((0, 0), 960, 608),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be

ResizeLayer((0, 0), SIZE[0], SIZE[1])

right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first argument is the initial size, and the next parameters are the new width and new heights. However, the initial size of the image is not being used in any of the layers...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill change that rn

@DaniParr DaniParr requested a review from cbrxyz April 16, 2024 18:58
cbrxyz
cbrxyz previously approved these changes Apr 22, 2024
Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cbrxyz cbrxyz merged commit 96ce89c into master Apr 22, 2024
4 checks passed
@cbrxyz cbrxyz deleted the vision_stack_implementation branch April 22, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants