Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calc_heading #77

Closed
4 tasks done
ufechner7 opened this issue Oct 4, 2024 · 4 comments
Closed
4 tasks done

Fix calc_heading #77

ufechner7 opened this issue Oct 4, 2024 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers priority to be fixed first

Comments

@ufechner7
Copy link
Owner

ufechner7 commented Oct 4, 2024

This is broken since on the main branch because I changed the sign of the y-axis of the kite reference frame.

To fix it:

  • add a unit test for orientation = 0,0,0
  • add unit tests for different roll angles
  • add unit tests for different pitch angles
  • add unit tests for different yaw angles

These tests need to be executed for different wind directions.

You can find a graphical definition of the heading angle here: https://ufechner7.github.io/KiteUtils.jl/dev/reference_frames/

image

@ufechner7 ufechner7 self-assigned this Oct 4, 2024
@ufechner7 ufechner7 added bug Something isn't working good first issue Good for newcomers labels Oct 4, 2024
@ufechner7
Copy link
Owner Author

ufechner7 commented Oct 4, 2024

Development happens in the fix_yaw branch. One of the test scripts is examples_3d/parking_4p.
To run this script, execute:

julia --project
using Pkg
Pkg.update()
include("examples_3d/parking_4p.jl")

@ufechner7
Copy link
Owner Author

ufechner7 commented Oct 4, 2024

Shall be fixed in #78
The core routines are in the KiteUtils package in the file https://github.com/ufechner7/KiteUtils.jl/blob/main/src/trafo.jl

TODO:

  • document the definition of the KiteSensor (KS) reference frame
  • document the definition of the Earth Xsens (EX) reference frame

@ufechner7 ufechner7 pinned this issue Oct 4, 2024
@ufechner7 ufechner7 added the priority to be fixed first label Oct 4, 2024
@ufechner7
Copy link
Owner Author

Related: #81

@ufechner7
Copy link
Owner Author

ufechner7 commented Oct 17, 2024

Not using the fix_yaw branch any longer. Replaced by #84

@ufechner7 ufechner7 unpinned this issue Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers priority to be fixed first
Projects
None yet
Development

No branches or pull requests

1 participant