Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FENGSHA and dust schemes #10

Closed

Conversation

bbakernoaa
Copy link
Collaborator

This PR address #9

Major changes are:

  • Update to all dust schemes to allow an arbitrary number of bins in each of the schemes
  • Code cleanup for each of the dust schemes
  • Update fengsha to the latest version used in the UFS, i.e. RRFS-SD, AQM, and UFS-Aerosols

@bbakernoaa bbakernoaa added the enhancement New feature or request label Sep 1, 2023
@bbakernoaa bbakernoaa self-assigned this Sep 1, 2023
parameters/dust_data_mod.F90 Outdated Show resolved Hide resolved
src/dust_afwa_mod.F90 Outdated Show resolved Hide resolved
@bbakernoaa
Copy link
Collaborator Author

@jianheACM @jordanschnell @zmoon Please take another look at this. Fixed it up and is producing the same results.

@jordanschnell I updated the all the dust schemes to pass the tendencies out and then update in the catchem_dust_driver. Please take a look.

@bbakernoaa
Copy link
Collaborator Author

I have a sample run on HERA here: /scratch2/NCEPDEV/stmp3/Barry.Baker/COMROT/test2/gfs.20160715

@bbakernoaa
Copy link
Collaborator Author

@rschwant @jordanschnell @jianheACM @zmoon Please take another look at this we need to move forward

@jordanschnell
Copy link
Collaborator

@jianheACM @jordanschnell @zmoon Please take another look at this. Fixed it up and is producing the same results.

@jordanschnell I updated the all the dust schemes to pass the tendencies out and then update in the catchem_dust_driver. Please take a look.

This part looks good to me. As I mentioned and @zmoon noted, would be good to have a single line to add the emissions but I recognize there are slight differences so all good for now.

zmoon pushed a commit to zmoon/CATChem that referenced this pull request Jun 3, 2024
@bbakernoaa bbakernoaa closed this Aug 19, 2024
@bbakernoaa bbakernoaa deleted the feature/update_fengsha branch September 13, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants