Merge develop into master #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update sfc_climo_gen and chgres_cube programs: For regrid options other than conservative and neighbor, change pole method from NONE to ALLAVG. This prevents interpolation problems near the poles.
develop: This commit references #27. Update chgres_cube - Initialize all surface variables to a missing flag after the FieldCreate step. In routine qc_check explicitly set snow to zero at open water and ice depth to zero at non-ice points.
develop: This commit references #32. Updates to chgres_cube: 1) Ensure sea ice fraction does not exceed 1.00. 2) Update 'model_grid.F90' to use separate pointers for the center and corner point lat/lons for gaussian grids. Recycling the same pointer for both could cause problems.
Update chgres_cube to zero out vertical velocity when using tiled history files or tile restart files as input. See issue #31 for details.
Update chgres_cube program to ingest GFS grib2 data. For more details see issue #7
Replace obsolete account code 'FV3GFS-T2O' with new code 'GFS-DEV' in all Cray and Dell scripts.
Update the fre-nctools build module on Jet to use Intel v18 and impi 2018.4.274. Per request of HAFS team.
Update the old serial chgres and global_cycle programs to use hdf5_parallel v1.10.6 and netcdf parallel v4.7.4 on Hera and Dell. Supports GFS V16. See issue #26 for more details. Also, fix an out-of-bounds array in serial chgres discovered by Dusan.
NOAA legal approved licenses for our component repositories. For EMC components we are using the LGPL.
Baseline set of utility scripts to start a GDAS/ENKF cycle using FV3GFS data as input. The scripts pull the needed data from HPSS and run the chgres_cube program for the high-res and ENKF members. chgres_cube - Fix three argument mismatches in call to error handler routine (see #69 for details). Update Cray build module to point to my own copy of the wgrib2 api instead of Dusan's. Point to official version of ESMF v8 on Cray and Dell. This commit references #33.
Update/add documentation from v1.0.0 of the public release branch. Update LICENSE.md. Add VERSION file and docs directory. See issue #87 for more details.
Add range check to remove bad SST values (< 271.2K or > 310K) when using v14, v15.1 and v15.2 GFS GRIB2 data. Bad values are the result of bi-linear interpolation from the gaussian master files to the lat/lon "pgb" files. As a result, coastal points (even those identified as water by the mask) can be a mixture of land and non-land. This also fixes a model failure discovered when testing v1 of the public release. See issue #59 for more details.
Update chgres_cube to ingest GFS v16 gaussian netcdf history files. Input type "gaussian_netcdf". Add regression test for new option. For clarity, rename these input types (gaussian -> gaussian_nemsio; gfs_gaussian -> gfs_gaussian_nemsio; gfs_spectral -> gfs_sigio). Update all scripts and the GDAS initialization utility accordingly.
New regression tests for global_cycle, emcsfc_ice_blend, emcsfc_snow2mdl and all programs associated with the grid generation.
Build all UFS_UTILS programs using CMake. Update all driver scripts to load the same module file as the build script. This ensures the build and the run scripts use the same compiler version and libraries. Remove all files associated with the old build system.
On June 1, the directory 'project' was changed to 'HFIP'. And on June 30, the /lfs3 disk will be replaced by /lfs4. The repository was updated accordingly. For details, see issue #107.
Add module load of 'prod_util' to the Hera, Cray and Dell build/run modules. This will define the NDATE program for the GDAS initialization scripts. This fixes a bug that was added when the CMake version of UFS_UTILS was merged. For details see #115
Update chgres_cube to optionally process climatological Thompson MP tracers. To process these tracers, the namelist variable "thomp_mp_climo_file" is set to the path/name of the climo file (netcdf). If variable is not set, the tracers will not be processed. For more details see #106.
Add capability to create regional extended Schmidt gnomonic grids (from Jim Purser). Includes new program to compute the global equivalent resolution for a regional grid (from Gerard). Move programs filter_topo, global_equiv_resol, regional_esg_grid and shave from fre-nctools.fd to its own directory. fre-nctools.fd should only contain the GFDL tools. For details, see #4 and #125
Adding the lake maker from Shan Sun and Ning Wang: generate lake fraction and depth on the FV3 grid and add these records to the orography files. Ensure land fraction and lake fraction are consistent. For details, see issue #111
* cleanup of user_guides * landing page cleanup * fixed some doxygen warnings * added some code authors to the README * fixed driver.f90 reference * added slideshow and reference in README * more documentation improvements * adding brew update
Create rt.sh script for automatic regression tests on NOAA HPC systems
These scripts are no longer used by NCEP workflows. Fixes #266.
* converted to MPI test * MPI test scripts for hera, orion, and jet * Fix syntax * Make scripts executable, pass account to srun * Add qos Co-authored-by: kgerheiser <kgerheiser@icloud.com> Co-authored-by: Kyle Gerheiser <3209794+kgerheiser@users.noreply.github.com>
…Purser (#439) * added slideshow and reference in README * added Jim Pursers documentation edits for pmat4.f90
…stency check." (#440) * added slideshow and reference in README * changed regression to the more honest consistency test * changed regression to the more honest consistency test * changed regression to the more honest consistency test * changed regression to the more honest consistency test * more changes of regression to consistency
…#444) * added slideshow and reference in README * removed stray question marks * added authors to filter_topo.f90 * added authors to filter_topo.f90 * last edits from Jim Purser
Update error messaging in the global_cycle program to conform to the NCO standard. The standard is to preface all error messages that stop program execution with "FATAL ERROR". Fixes #368.
Add a unit test for search_util.F90. Two types of search tests were added: First, a missing value is replaced with a valid neighboring value. Second, a missing value is replaced by a default value. Fix bug in sst_guess routine within search_util.F90 which resulted in below freezing default values at points south of 60 degrees south latitude. Fixes #279 Fixes #441
…ing (#445) Make a library for each utility that includes all the files except the main program. Then, tests can link to that library to access necessary code.
Fix legacy extension warning for write statement in surface.F90. Remove some unused variables that can cause warnings depending on the compiler. Fixes #450
Define all constants as parameters and use uppercase. Add more descriptive prolog. Fixes #278
…t config_fv3_tiled_warm_restart (#457) * added slideshow and reference in README * uncommented failing test code * trying to fix namelist * fixing test * beefed up test * beefed up test * more testing * more testing * added test code * removed incorrect comment
* added slideshow and reference in README * improving documentation of soil parameters
* added slideshow and reference in README * show errors
…rtran10 (#469) turn on -fallow-argument-mismatch in chgres_cube for gfortran10
* Add version checking for each library * Improve beta message and remove MODULE from find_package * Relax version restriction on NetCDF to 4.3.3 * Add version to ESMF message * Enforce NetCDF 4.7.4 and switch to it on WCOSS Cray * Relax NetCDF version to 4.3.3 for WCOSS Cray
* Fix for seg fault in forecast step with GEFS. * chgres_cube: Correct erroneously high soil temperatures at isolated points in GEFS data by replacing it with skin temperature. Addresses Issue #447 * chgres_cube: Move do loop / if statement block for correcting erroneous soil temperatures to its own subroutine. * chgres_cube: Remove commented code that was previously used for the check on soil temperature. * First attempt at creating a test for check_soilt routine. * Bug fix for incorrect index order in check_soilt. Updates to test, which now passes. * Revert "Fix for seg fault in forecast step with GEFS." This will need to be done in a unique subroutine in input_data This reverts commit 0c0ff98. * Updated comments associated with check_soilt and its test to be more accurate. * Changed constant icet_default to be in ALL CAPS Co-authored-by: Christina.Holt <Christina.Holt@noaa.gov> Co-authored-by: Edward Hartnett <38856240+edwardhartnett@users.noreply.github.com>
Variable was removed by accident
Re-add NETCDF env variable so CMake can find NetCDF on WCOSS Cray
Fix install of lakefrac and inland
* added slideshow and reference in README * changed version
* added slideshow and reference in README * added utility name to test names in cmake output
edwardhartnett
approved these changes
Apr 30, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #484
@edwardhartnett I ran a
git pull upstream developon the master branch from the command line and didn't get any conflicts.