Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/public v1 #76

Conversation

valbonakunkel-noaa
Copy link

in the docs folder, "CHGRES_CUBE.rst" file is added

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section on how to compile is not current.

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two nomads links are broken. The YYYYMMDD/HH are for illustrative purposes only. The links should point to https://nomads.ncep.noaa.gov/pub/data/nccf/com/gfs/prod/

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nomads links are still not correct. The actual link should point to: https://nomads.ncep.noaa.gov/pub/data/nccf/com/gfs/prod/. The text displayed should include "gfs.YYYYMMDD/HH"

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links work now.

Some of the bulleted sections are in light gray "ink", which looks odd. I am displaying thru github, which may not read this format correctly.

@valbonakunkel-noaa
Copy link
Author

valbonakunkel-noaa commented Feb 26, 2020 via email

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Information looks correct. Valbona said it is displaying correctly.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 1cea3ad into ufs-community:release/public-v1 Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants