Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc only: change to lower case #84

Merged

Conversation

ligiabernardet
Copy link

Change file name and file content from CHGRES_CUBE to chgres_cube. Restructure subsections so they are now sections.

@GeorgeGayno-NOAA GeorgeGayno-NOAA self-requested a review March 3, 2020 13:16
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Mar 3, 2020
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under section "Where to find GFS GRIB2 and NEMSIO data", the two nomads links are broken.

The actual link should be: https://nomads.ncep.noaa.gov/pub/data/nccf/com/gfs/prod/

The data itself is under the "/gfs.YYYYMMDD/HH" sub-directory. How best to convey that to the user?

@ligiabernardet
Copy link
Author

Your comments have been addressed in the modified doc.

@GeorgeGayno-NOAA GeorgeGayno-NOAA self-requested a review March 3, 2020 17:16
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Will merge.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 2d5a206 into ufs-community:release/public-v1 Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants