New BNU soil type and VIIRS vegetation type data #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as required by the new 30s data. Fixes ufs-community#821.
as required by the new 30s data. Fixes ufs-community#821.
the 0.5-degree version of the soil substrate temperature which will allow the use of more MPI tasks. Fixes ufs-community#821.
5 tasks
viirs data. Fixes ufs-community#821.
|
The list of files that need to be added/removed from the 'fixed' directories is here: #821 (comment) |
|
@WalterKolczynski-NOAA or @KateFriedman-NOAA - this PR requires three new files in the
The new 'veg' and 'soil' files replace earlier versions with bad 'glacial' points. Can these be removed or moved to a deprecated directory? These bad files are:
|
@GeorgeGayno-NOAA can you open a global-workflow "Fix File Update" issue with these details? We'll make the update. Thanks! |
4 tasks
that contains the new soil and veg files. Fixes ufs-community#821.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
A new version of the VIIRS vegetation type data was created that removes spurious snow points in warm regions.
And a new version of the BNU soil type data was created that is compatible with the updated vegetation data.
It also includes additional records for the percentage and sand and clay.
Only high-res versions of these data (global 30 second) will be baselined. Previous versions of these data included several lower-res versions that reduced the computational resources required to create model grids. Due to a quirk in the ESMF library, increasing the number of MPI tasks for high-res input data can cause a failure when processing low-res data, such as the soil substrate temperature data. Therefore, a resampled (0.5-degree) version of the 2.6x1.5 degree soil substrate data will be baselined as well.
Update UFS_UTILS to use this new data.
TESTS CONDUCTED:
These tests were done using 76a3b02
All
grid_genconsistency tests failed as expected. One source of the failure was the use of the new soil substrate temperature. That data was resampled to higher resolution. Also, the current low-res data has incorrect geo-referencing. Some comparisons using the new and current substrate data are documented in #821.The "c96.viirs.bnu" test showed differences beyond the substrate temperature field. That is because it used the new 'v3' soil and vegetation type data. These differences were visually compared against the baseline files and found to be reasonable and expected.
All baseline test data will be updated on all machines after the merge.
DEPENDENCIES:
The new soil, veg and soil substrate files must be added to the official 'fix' directories on all machines.
The following snow-contaminated files should be removed:
DOCUMENTATION:
Update 'readthedocs' for new input data:
https://georgegayno-noaaufs-utils.readthedocs.io/en/bugfix-bnu_soil/ufs_utils.html#id58
ISSUE:
Fixes #821.
Related to #803.
CONTRIBUTORS:
@barlage