-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change FVCOM background IO to read 32-bit surface restart files. #848
Conversation
@hu5970 - the unit test fails to compile: https://github.com/hu5970/UFS_UTILS/tree/fvcom_32bit/tests/fvcom_tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test won't compile.
@GeorgeGayno-NOAA Could you tell me how to find error message? |
In the |
@hu5970 What is the status of this? |
@GeorgeGayno-NOAA George, I am on vacation this week and next week. I will try "-DBUILD_TESTING=ON" if I have time but my response will be slow. Thanks, Ming |
It is working now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @hu5970! It looks like it is passing the unit test.
@hu5970 Let me do a few final checks. Then, we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments addressed by developer. All tests passed. Will merge.
@GeorgeGayno-NOAA @dmwright526 Thanks. Ming |
DESCRIPTION OF CHANGES:
RRFS uses 32-bit CCPP and it generates 32-bit surface restart file instead of 64-bit restart files.
This requires to change the interface of FVCOM to read 32-bit variables instead of 64-bit variables.
TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
Describe any additional tests performed.
Note: this code does not have any consistency tests.
ISSUE:
Fixes issue mentioned in #847