sfc_climo_gen - use scale parameter to read scaled datasets

[sanatcumar]

DESCRIPTION OF CHANGES:

Update sfc_climo_gen to use optional scaling parameter to read surface fields when used.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

• Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2).
• Compile branch on Hera using GNU.
• Compile branch in 'Debug' mode on WCOSS2.
• Run unit tests locally on any Tier 1 machine.
• Run relevant consistency tests locally on all Tier 1 machines.

Describe any additional tests performed.

DEPENDENCIES:

Add any links to pending PRs that are required prior to merging this PR. For example:

ufs-community/UFS_UTILS/pull/<pr_number>

DOCUMENTATION:

If this PR is contributing new capabilities that need to be documented, please also include updates to the RST files in the docs/source directory as supporting material.

ISSUE:

Fixes #957.

[GeorgeGayno-NOAA]

@sanatcumar - there should be a list of tests in the description section (automatically added via by this file: https://github.com/ufs-community/UFS_UTILS/blob/develop/.github/PULL_REQUEST_TEMPLATE)

I will add them manually.

[GeorgeGayno-NOAA]

@sanatcumar - what is the status of this PR?

[sanatcumar]

@sanatcumar - what is the status of this PR?

Hi George , I was waiting on using this new data sets for some test runs before I do this. This also involves adding a new data set to the fix directories. Could you refresh my memory on whom to contact or to raise a new dependency issue ?

I see you have added from template. Thanks. I will do some quick checks and request a review soon.

Cheers and thanks again

[GeorgeGayno-NOAA]

@sanatcumar - what is the status of this PR?

Hi George , I was waiting on using this new data sets for some test runs before I do this. This also involves adding a new data set to the fix directories. Could you refresh my memory on whom to contact or to raise a new dependency issue ?

I see you have added from template. Thanks. I will do some quick checks and request a review soon.

Cheers and thanks again

If you want new 'fixed' data hosted to the official baselines, make your request here (fixed file update): https://github.com/NOAA-EMC/global-workflow/issues/new/choose

[GeorgeGayno-NOAA]

Your branch looks out of date. Merge the latest updates from 'develop'.

Also, I see a branch called 'use_scale' in the authoritative fork. What is that? All branches should be in user forks.

[sanatcumar]

Your branch looks out of date. Merge the latest updates from 'develop'.

Also, I see a branch called 'use_scale' in the authoritative fork. What is that? All branches should be in user forks.

Hi George, Just synced to the latest develop and also deleted the branch in the authoritative fork. Thanks for pointing it out .

[GeorgeGayno-NOAA]

@sanatcumar - did you perform any of the tests under "TEST CONDUCTED". If you don't have access to a machine listed, let me know and I can run the tests for you.

[sanatcumar]

@sanatcumar - did you perform any of the tests under "TEST CONDUCTED". If you don't have access to a machine listed, let me know and I can run the tests for you.

Hi @GeorgeGayno-NOAA , thanks,
I have run it on Hera and can on Orion . I do not have access to others.
I changed my Phone and now my RSA needs to be setup again for access to Orion though. I am working on it.