Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warning #969

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Fix compiler warning #969

merged 3 commits into from
Jul 16, 2024

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Jun 27, 2024 •
edited
Loading

DESCRIPTION OF CHANGES:

Add void insertIntersect function declaration to ./sorc/fre-nctools.fd/shared_lib/mosaic_util.h

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on all Tier 1 machines using Intel. Done using 769a54f.
  • Compile branch on Hera using GNU. Done using 769a54f.
  • Compile branch in 'Debug' mode on WCOSS2. Done using 769a54f. No warnings.
  • Run unit tests locally on any Tier 1 machine. Done on Hera using 769a54f.
  • Run grid_gen consistency tests locally on all Tier 1 machines. Done using 769a54f. All tests passed.

DEPENDENCIES:

None.

DOCUMENTATION:

N/A

ISSUE:

Fixes #959.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review July 8, 2024 20:56
@GeorgeGayno-NOAA
Copy link
Collaborator Author

@MatthewPyle-NOAA - can you please review?

@MatthewPyle-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA Will try to take a look later today or tomorrow.

MatthewPyle-NOAA
MatthewPyle-NOAA approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it cleans up the compiler warnings previously seen.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 47705d5 into ufs-community:develop Jul 16, 2024
4 checks passed
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the rm_warning branch July 16, 2024 12:37
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UFS_UTILS that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
d3bb0ea 
* origin/develop:
  Update the C192 default ocean resolution in the gdas_init utility (ufs-community#980)
  Use HPC-stack libraries on WCOSS2 (ufs-community#975)
  Fix compiler warning in fre-nctools.fd (ufs-community#969)
  Fix Gnu compilation on Hera (ufs-community#965)
  Update fixed data directory path for Gaea (ufs-community#972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewPyle-NOAA MatthewPyle-NOAA MatthewPyle-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compile warnings in UFS_UTILS code
2 participants
@GeorgeGayno-NOAA @MatthewPyle-NOAA