Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit testing to ocean_merge program #997

Merged
merged 25 commits into from
Nov 26, 2024

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Nov 15, 2024

DESCRIPTION OF CHANGES:

Refactor the ocean_merge code into subroutines. Add unit testing.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2).
  • Compile branch on Hera using GNU. Done using aff1a41.
  • Compile branch in 'Debug' mode on WCOSS2. Done with no warnings using aff1a41.
  • Run unit tests locally on any Tier 1 machine. All tests passed with aff1a41. (Used IntelLLVM on Hercules and Hera; used Gnu on Hera; used Intel Classic on WCOSS2)
  • Run grid_gen consistency tests locally on all Tier 1 machines. Done using aff1a41. All passed on Jet, Hera, Hercules, Orion and WCOSS2.

The current grid_gen consistency tests don't exercise the ocean_merge program, so a C192 grid was created using on Hercules using the script in ./driver_scripts. Output orography files from the branch at aff1a41 and the develop at 122010e were identical. It was then decided to update one of the tests to invoke ocean_merge. This was done at afb59a4. See comment

DEPENDENCIES:

None.

DOCUMENTATION:

The new ocean_merge routines need Doxygen comments.

  • Create Doxygen with no warnings due to the ocean_merge code. Done on Hera using aff1a41.

ISSUE:

Fixes #944.

George Gayno and others added 24 commits September 26, 2024 12:41
routines into their own library.

Write a unit test for the namelist read routine.

Fixes ufs-community#944.
@GeorgeGayno-NOAA
Copy link
Collaborator Author

After some thought, I decided to update the c96.uniform regression test to invoke the ocean_merge step. Done at afb59a4. The updated test will require a new baseline on all machines.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review November 19, 2024 20:53
Copy link
Collaborator

@sanatcumar sanatcumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build the latest commit , Ran the default C96.mx100. Identical files as compared to previous runs. Ran the new test on Hera and all tests passed with the updated baselines

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 5e1138e into ufs-community:develop Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create unit tests for ocean_merge code
2 participants