GF radar reflectivity update for RRFS realtime runs #103
Conversation
haiqinli
requested review from
Qingfu-Liu,
dustinswales,
grantfirl,
lisa-bengtsson and
mzhangw
as code owners
physics/cu_c3_deep.F90
Outdated
| po_cup,qes_cup,pwavo,edto,pwevo,pre,outt,outq) !,outbuoy) | ||
| ! call rain_evap_below_cloudbase(itf,ktf,its,ite, & | ||
| ! kts,kte,ierr,kbcon,xmb,psur,xland,qo_cup, & | ||
| ! po_cup,qes_cup,pwavo,edto,pwevo,pre,outt,outq) !,outbuoy) | ||
|
|
There was a problem hiding this comment.
I would suggest to just remove these lines.
There was a problem hiding this comment.
I suggest we keep this just in case we need to tune with subcloud evaporation in the future.
There was a problem hiding this comment.
We've been recommending that folks remove code rather than comment it out because folks often forget why they left commented code in and it makes the code harder to read in the long run. Git saves the history, so one can always go back to a commit before this PR and put these lines back in.
There was a problem hiding this comment.
Ok, I will remove these commented lines.
| cuprate = max(0.1,1.e3*raincv(i) * 3600.0 / dt) ! cu precip rate (mm/h) | ||
| if(cuprate .lt. 0.05) cuprate=0. | ||
| ze_conv = 300.0 * cuprate**1.5 | ||
| if (maxupmf(i).gt.0.1 .and. cuprate.gt.0.) then |
There was a problem hiding this comment.
Is not cuprate always >0 after adjustment? Any reason to change cuprate and add the condition of cuprate>0?
There was a problem hiding this comment.
Is not cuprate always >0 after adjustment? Any reason to change cuprate and add the condition of cuprate>0?
In line 73, If the convective precipitation rate is very weak (<0.05 mm/h), the cuprate is reset to 0. Thus in the if condition of line 75, we exclude the case with weak convective updraft and weak convective precipitation.
There was a problem hiding this comment.
The problem is in line 72, cuprate will be always >0.1 mm/h.
There was a problem hiding this comment.
Thanks for catching that. Yes, we have duplicated safeguards. I will update line 72 just as "cuprate = 1.e3*raincv(i) * 3600.0 / dt" in this PR soon.
|
@haiqinli I've reviewed this and am ready to approve once the remaining comments are addressed. |
|
@grantfirl This PR has been updated to address the reviewers' comments. Thank you very much! |
This PR is for RRFS_A and RRFS_B realtime runs. It includes the convective precipitation unit bug fix in GF radar reflectivity, soil moisture bug fix and updates for dust modules, and also the C3 convection updates.