Fix incorrect intents. #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinswales
requested review from
grantfirl,
Qingfu-Liu and
mzhangw
as code owners
mzhangw
reviewed
Apr 25, 2024
mzhangw
reviewed
Apr 25, 2024
| @@ -430,7 +430,7 @@ | |||
| dimensions = (horizontal_loop_extent,vertical_layer_dimension,number_of_tracers) | |||
| type = real | |||
| kind = kind_phys | |||
| intent = inout | |||
| intent = in | |||
There was a problem hiding this comment.
The fortran code has this as intent(in). Change is needed here to match
grantfirl
reviewed
Apr 25, 2024
| @@ -43,10 +43,10 @@ subroutine GFS_MP_generic_post_run( | |||
| integer, intent(in) :: index_of_temperature,index_of_process_mp,use_lake_model(:) | |||
| integer, intent(in) :: imfshalcnv,imfshalcnv_gf,imfdeepcnv,imfdeepcnv_gf,imfdeepcnv_samf | |||
| integer, dimension (:), intent(in) :: htop | |||
| integer :: dfi_radar_max_intervals | |||
| integer, intent(in) :: dfi_radar_max_intervals | |||
There was a problem hiding this comment.
This variable isn't being used in the code as far as I can tell. Can we just take it out?
grantfirl
approved these changes
Apr 25, 2024
Qingfu-Liu
approved these changes
Apr 29, 2024
joeolson42
approved these changes
Apr 29, 2024
|
@dustinswales I'd like to combine this with other PRs to save on the UFS merge process. Are you OK if I do this? My understanding is that this should not change RT results. |
This was referenced May 7, 2024
|
Combined into #205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some inconsistencies in fortran/metadata were discovered when using Capgen. Capgen's Fortran parser uncovered these mismatch in argument intents.