Bug fix for rain evaporation due to inconsistent application of air density on a few lines #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on multiple lines
gthompsnWRF
requested review from
RuiyuSun,
grantfirl,
Qingfu-Liu and
dustinswales
as code owners
|
I have no idea why prebuild-SCM is failing. |
Qingfu-Liu
approved these changes
Apr 27, 2023
It's failing because the SCM is only caught up to NCAR:main, which is behind ufs/dev by a couple of commits. This check is more of a "heads up" to code managers that this PR (or previous ones, in this case) require changes to the SCM's variable declaration/allocation. This is expected and nothing to worry about. |
grantfirl
approved these changes
Apr 27, 2023
|
@Qingfu-Liu @gthompsnWRF I'll be responsible for creating super-repository PRs. |
RuiyuSun
approved these changes
Apr 28, 2023
This was referenced May 3, 2023
|
Closing this PR because it is now combined with #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculations of rain evaporation rate (variable called
prv_rev) had some mismatching of units due to air density inconsistencies. The set of 3 lines will fix it causingprv_revto be kg kg-1 s-1 as it should be ahead of adding it to the principle tendency terms.This was discovered with the help of Ruiyu Sun and Eric Aligo (NCEP-EMC) due to discovering a few grid points with larger than 100% RH (with respect to water) due to the improper rate limiter.