-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for new NSSL-MP namelist parameters #77
Conversation
…minor naming tweak for these parameters in the code.
Question: Does SCM need to be updated now, too, or is that a bridge to cross later? OK, done here: NCAR/ccpp-scm#385 |
Typically, CCPP code managers handle any changes in FV3 that need to be brought over to the SCM, but thanks for going the extra mile. |
@MicroTed I'd like to ask you if you'd be willing to bring in the changes from #76 to this PR to reduce code management workload. That PR changes baselines, but it is only a build system change for the UGWP scheme. I would be responsible for testing the combined PR to make sure it is behaving as expected. |
@grantfirl Sure, that shouldn't be much trouble. Done. |
Revert combination, update to ufs/dev, and update CODEOWNERS
@MicroTed Please update this branch to the latest ufs/dev branch when you get a chance. |
@grantfirl I am getting a conflict in ccpp/physics/CMakeLists.txt. The second half is from #76, and I think that was taken back out of this PR? So should whole thing be removed or no? Never mind -- I forgot to pull my branch, haha |
Ya, all CMakeLists.txt changes should be removed. So, you can delete everything between the |
Testing on UFS-WM PR #1775 is complete. Feel free to go ahead and merge this sub-pr. @grantfirl |
@Qingfu-Liu @dustinswales If you have permission, please, go ahead to merge this pr. |
sync with the ufs/dev
Add documentation lines for new namelist parameters (nssl_alphar, nssl_ehw0, nssl_ehlw0) with a minor name tweak.
Also, nssl_params(14) is used by another version, so this is changed to nssl_params(15) for consistency (no effect)
Follow-up on #45 (@JiliDong-NOAA)