Ensemble mode bug fix #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/ensemble_bug_fix
…namelist sections of FV3.input.yml
JeffBeck-NOAA
requested review from
BenjaminBlake-NOAA,
gsketefian,
JulieSchramm,
mkavulich and
RatkoVasic-NOAA
gsketefian
approved these changes
Aug 21, 2020
christinaholtNOAA
pushed a commit
to christinaholtNOAA/regional_workflow
that referenced
this pull request
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Fix bug in DO_ENSEMBLE portion of setup.sh that would cause ensemble mode to fail unless the entry for this variable was explicitly defined as "TRUE", and not "True", "true", "YES", or "yes".
Remove "!!python/none" entries for "nam_sfcperts" and "nam_stochy" for all CCPP SDFs in FV3.input.yml. This change was necessary to correctly allow stochastic physics to work with any SDF. A value of "!!python/none" for "nam_stochy" would result in any of the ad-hoc schemes failing, since the appropriate values in input.nml.FV3 for the "nam_stochy" section would not be present in the final input.nml file. The "!!python/none" entries for "nam_sfcperts" were also removed for all SDFs to allow users to potentially take advantage of those perturbations in the future.
TESTS CONDUCTED:
Ran two 25-km CONUS end-to-end tests on Hera using all three ad-hoc schemes with the FV3_GSD_SAR and FV3_GFS_2017_gfdlmp CCPP SDFs with FV3GFS ICs and LBCs.
CONTRIBUTORS:
@gsketefian