Adding gsl gwd oro data files #448
Conversation
mdtoy
requested review from
BenjaminBlake-NOAA,
gsketefian,
JeffBeck-NOAA,
JulieSchramm and
mkavulich
as code owners
|
@mdtoy This looks good. Just a minor request: In the PR message, can you mention for config_defaults.sh that you removed the workflow variable GWD_HRRRsuite_BASEDIR since it's no longer needed? Once you do that and update the comment in exregional_make_orog.sh, it's just a matter of waiting for the UFS_UTILS PR #273 to get merged (looks like it hasn't been merged yet). |
…nerating oro_data files instead of copying them
… into adding_gsl_gwd_oro_data_files
… into adding_gsl_gwd_oro_data_files
| grid_fp="${FIXLAM}/${grid_fn}" | ||
| ls_fn="geo_em.d01.lat-lon.2.5m.HGT_M.nc" | ||
| ss_fn="HGT.Beljaars_filtered.lat-lon.30s_res.nc" | ||
| if [ "${MACHINE}" = "WCOSS_CRAY" ]; then |
There was a problem hiding this comment.
The --relative flag does not work on MacOS either, and probably many Linux distros if my glance at the various man pages out there is representative. Can we just omit the flag completely rather than introducing this logic?
There was a problem hiding this comment.
Sorry apparently I can't figure out GitHub's line-highlighting capability; this comment refers to the following several lines
|
@mdtoy, any update on this PR/@mkavulich's comment? |
|
Offline discussion resolved my issues, this PR can be merged. |
*** NOTE: This PR should be merged only after PR #273 into UFS_UTILS has been merged. ***
DESCRIPTION OF CHANGES:
Added the creation of orog_data files required for the GSL drag suite as part of the FV3_HRRR CCPP suite, by adding the execution of "orog_gsl", which was recently added to the UFS_UTILS repository. Before, these files were created manually, and the regional_workflow used to copy them to the appropriate destination.
Files changed:
scripts/exregional_make_orog.sh: The required fix files are located and copied over to the working directory and the "orog_gsl" executable is called, which generates the files "oro_data_ls*.nc" and "oro_data_ss*.nc".
tests/run_experiments.sh: Removed lines that used to copy pre-made oro_data files over to where they needed to go.
ush/config_defaults.sh: Added two files to the list of "fix" files needed to generate orog_data files. Removed the workflow variable GWD_HRRRsuite_BASEDIR since it's no longer needed.
ush/setup.sh: Removed lines involved with looking for pre-made orog_data files (the old method).
TESTS CONDUCTED:
Conducted experiments on Hera at:
/scratch1/BMC/wrfruc/mtoy/git_local/ufs-srweather-app/regional_workflow/tests/my_experiments.txt
These were:
grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_HRRR
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_HRRR_suite_HRRR
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_HRRR
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_HRRR
grid_RRFS_CONUS_3km_ics_HRRR_lbcs_RAP_suite_HRRR
nco_grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_HRRR
nco_grid_RRFS_CONUS_3km_ics_HRRR_lbcs_RAP_suite_HRRR
All tests were successful.
CONTRIBUTORS:
@gsketefian