-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add columns for relative test and time step to CSV file containing WE2E test info #776
Add columns for relative test and time step to CSV file containing WE2E test info #776
Commits on May 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bbb2978 - Browse repository at this point
Copy the full SHA bbb2978View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69bbccd - Browse repository at this point
Copy the full SHA 69bbccdView commit details
Commits on May 16, 2022
-
Improvements to the way shell functions return arguments:
1) Change names of variables that specify names of output variables from "output_varname_..." to "outvarname_...". 2) When setting the value of an output variable, do so only if the corresponding "outvarname_..." variable is passed into the function. 3) Bugfix: In "printf -v ..." statements, the "%s" was omitted. Include these.
Configuration menu - View commit details
-
Copy full SHA for 9a3bfc2 - Browse repository at this point
Copy the full SHA 9a3bfc2View commit details
Commits on May 18, 2022
-
Improvements to set_gridparams_GFDLgrid() function to make it easier …
…to call independently: 1) Replace the global variable VERBOSE with the input argument "verbose". 2) Remove if-statements involving RUN_ENVIR. These were needed when EMC was using GFDLgrid type grids that were not symmetric about the center of the tile, but now that EMC is using ESGgrid-type grids, they are no longer needed.
Configuration menu - View commit details
-
Copy full SHA for a0d60f3 - Browse repository at this point
Copy the full SHA a0d60f3View commit details -
Move constants NH0, NH3, and NH4 to the constants.sh file so that the…
…y can be available outside of workflow generation (e.g. during the generation of the CSV file containing test information) by sourcing constants.sh. Details: 1) Move constants NH0, NH3, and NH4 needed in grid generation from setup.sh to the constants.sh. 2) During experiment generation (in setup.sh), place the contents of constants.sh at the top of var_defns.sh. 3) Define new variable CONSTANTS_FN in config_defaults.sh that defines the name of the constants definition file. 4) Source constants.sh in get_gridparams_GFDLgrid.sh in order to have access to NH0, NH3, and NH4 (since those are no longer in config_defaults.sh). 5) Bug fixes in "printf -v ..." commands in setup.sh. 6) Source constants.sh in valid_param_vals.sh so that the constant array "valid_vals_Boolean" can be used in valid_param_vals.sh.
Configuration menu - View commit details
-
Copy full SHA for d2ed446 - Browse repository at this point
Copy the full SHA d2ed446View commit details -
In the function set_gridparams_ESGgrid(), change USHDIR to the local …
…variable ushdir and set it within the function to allow the function to be used outside of the workflow generation (e.g. when creating a CSV file containing WE2E test information).
Configuration menu - View commit details
-
Copy full SHA for 3123459 - Browse repository at this point
Copy the full SHA 3123459View commit details -
Changes to allow the function set_predef_grid_params() to be called o…
…utside of the workflow generation framework (e.g. to enable calling it from get_WE2Etest_names_subdirs_descs.sh to generate the CSV file containing WE2E test information): 1) Change USHDIR to the local variable ushdir and set the latter locally within the function. 2) Change PREDEF_GRID_NAME to predef_grid_name and make the latter a required input argument. 3) Change DT_ATMOS, LAYOUT_X, LAYOUT_Y, and BLOCKSIZE to dt_atmos, layout_x, layout_y, and blocksize and and make the latter set optional input arguments. If these are provided, then they remain the same within the function. If they are not provided (or are provided but their value is a null string), they get reset to the default value for the specified predefined grid (predef_grid_name). 4) Change QUILTING to quilting and make the latter a required input argument. 5) Change the grid parameters that this function sets for a given grid into local variables that get reset to null strings and instead provide as input arguments the names of output variables ("outvarname_...") that can be used to return these local variables back to the calling function or script. Such local variables are returned only if a corresponding "outvarname_..." input argument is specified by the calling function or script. 6) Edit comments; add double quotes for consistency where necessary; remove empty lines or add them as needed. 7) Remove call to the function from within the file (at the end of the file). This means the function cannot be called simply by sourcing the file containing it. Instead, the file must be sourced, but then the function must be called separately (along with an argument list). This is to bring things in line with the way other functions are called in the SRW App.
Configuration menu - View commit details
-
Copy full SHA for b919577 - Browse repository at this point
Copy the full SHA b919577View commit details -
(1) Call the function set_predef_grid_params() with arguments (as req…
…uired with the new version of this function); (2) Rename local variables in set_predef_grid_params.sh (by adding double underscores to start and end) so they do not conflict with variable names passed to the function that will be the output variables (i.e. varaible names specified via "outvarname_..." input arguments).
Configuration menu - View commit details
-
Copy full SHA for 3f585be - Browse repository at this point
Copy the full SHA 3f585beView commit details
Commits on May 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6ec8321 - Browse repository at this point
Copy the full SHA 6ec8321View commit details -
Add new column listing the relative cost of running the dynamics in e…
…ach test (relative to running a single 6-hour forecast on the RRFS_CONUS_25km predefined grid).
Configuration menu - View commit details
-
Copy full SHA for 1b008af - Browse repository at this point
Copy the full SHA 1b008afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 975c16f - Browse repository at this point
Copy the full SHA 975c16fView commit details -
Add single quote to field value in CSV file to make sure it gets trea…
…ted as a string in google sheets (and doesn't get a number format automatically applied to it).
Configuration menu - View commit details
-
Copy full SHA for d3122e7 - Browse repository at this point
Copy the full SHA d3122e7View commit details -
Update y-dimension of write-component grid for 3km Indianapolis domai…
…n to correct value.
Configuration menu - View commit details
-
Copy full SHA for 4b11c67 - Browse repository at this point
Copy the full SHA 4b11c67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24de280 - Browse repository at this point
Copy the full SHA 24de280View commit details
Commits on May 20, 2022
-
In the WE2E test info CSV file, for readability split the test name a…
…nd alternate test name column contents into two lines.
Configuration menu - View commit details
-
Copy full SHA for 8376e0c - Browse repository at this point
Copy the full SHA 8376e0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7d523c - Browse repository at this point
Copy the full SHA d7d523cView commit details -
Quote the argument to the boolify() function because without quotes, …
…if the variable being passed is empty, boolify() will think no argument is being passed to it.
Configuration menu - View commit details
-
Copy full SHA for 55a8960 - Browse repository at this point
Copy the full SHA 55a8960View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85e8454 - Browse repository at this point
Copy the full SHA 85e8454View commit details -
Use the variable valid_vals_BOOLEAN provided in constants.sh to check…
… validity of the value of generate_csv_file. Use the boolify() function to set its value to "TRUE" or "FALSE".
Configuration menu - View commit details
-
Copy full SHA for d8187ac - Browse repository at this point
Copy the full SHA d8187acView commit details -
Add quotes around argument to boolify() function to make sure it unde…
…rstands that an argument is being passed in even if that argument happens to be an empty string.
Configuration menu - View commit details
-
Copy full SHA for 8039468 - Browse repository at this point
Copy the full SHA 8039468View commit details
Commits on May 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for eb9edb6 - Browse repository at this point
Copy the full SHA eb9edb6View commit details -
Add the boolean flag "generate_csv_file" as an input argument to the …
…script run_WE2E_tests.sh in order to allow users to prevent creation of a CSV file containing WE2E test information (since this can take a while). Default value of this argument is "TRUE", so users have to explicitly set it to "FALSE" on the command line to prevent generation of the CSV file.
Configuration menu - View commit details
-
Copy full SHA for 0978a4d - Browse repository at this point
Copy the full SHA 0978a4dView commit details -
Use the same method as other variables to set the experiment variable…
… EXEC_SUBDIR via the input argument exec_subdir.
Configuration menu - View commit details
-
Copy full SHA for e88ea11 - Browse repository at this point
Copy the full SHA e88ea11View commit details
Commits on May 23, 2022
-
For boolean experiment variables, remove the corresponding "valid_val…
…s_..." variables from valid_param_vals.sh since they can now all be replaced with valid_vals_BOOLEAN. In setup.sh, add validity checks for skipped boolean variables and place other checks into related groups.
Configuration menu - View commit details
-
Copy full SHA for 4d1deed - Browse repository at this point
Copy the full SHA 4d1deedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f1e896 - Browse repository at this point
Copy the full SHA 0f1e896View commit details
Commits on May 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4152dfb - Browse repository at this point
Copy the full SHA 4152dfbView commit details
Commits on May 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 14679b4 - Browse repository at this point
Copy the full SHA 14679b4View commit details