-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop]: Source task specific portions of var_defns.sh
#789
Closed
danielabdi-noaa
wants to merge
74
commits into
ufs-community:develop
from
danielabdi-noaa:feature/partial_var_defns
Closed
[develop]: Source task specific portions of var_defns.sh
#789
danielabdi-noaa
wants to merge
74
commits into
ufs-community:develop
from
danielabdi-noaa:feature/partial_var_defns
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielabdi-noaa
changed the title
Source task specific portions of
[develop]: Source task specific portions of Jun 9, 2022
var_defns.sh
var_defns.sh
danielabdi-noaa
force-pushed
the
feature/partial_var_defns
branch
2 times, most recently
from
June 27, 2022 19:32
c2dcc46
to
9dffc1b
Compare
…fs-community#775) * update input namelist of chgres_cube * update diag_table templates * update scripts * back to original * specify miniconda version on Jet
Only datetime type is now in quotes.
danielabdi-noaa
force-pushed
the
feature/partial_var_defns
branch
from
July 14, 2022 20:25
9dffc1b
to
7115763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Adds capability to source task specific sections of
var_defns.sh
file. This has some pros and cons, so I am not sure if it is a good idea yet.pro: Each task sources a subset of the environment variables it needs defined for it in
config_defaults.yaml
, along with common variables defined for all tasks. Different tasks could define the same variable name e.g.NNODES
, instead ofNNODES_FOR_FCST
,NNODES_FOR_POST
etc. So it is a good way to handle proliferation of tasks.con: Some variables could be shared by multiple tasks, a developer could start using a variable defined for
make_grid
inrun_fcst
etc. This maintainability issue is the main reason I don't like this approach and why I wanted to put it in a separate PR. Either the variable has to be put in a shared region, or the given task need to be told to use variables from the other task.For example,
make_orog
uses lots of variables defined formake_grid
in the current structure ofconfig_defaults.yaml
, so I have to do the following inexregional_make_orog.sh
:I am not convinced that this PR is a good idea so please let me know what you think about it.
The last commit has the changes relevant for this PR.
TESTS CONDUCTED:
I have run tests successfully on HERA
No failures on the following 56 tests
DEPENDENCIES:
DOCUMENTATION:
None
ISSUE (optional):
None
CONTRIBUTORS (optional):
@christinaholtNOAA