Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug compilation flag specification at top level #17

Merged

Conversation

MinsukJi-NOAA
Copy link
Collaborator

Resolves issue #16

  1. Debug flags are specified in coupledFV3_MOM6_CICE_debug.appBuilder
  2. Flags are used by NEMS MOM6 and CICE submodules to initiate debug makes
  3. All regression tests passed

1. Debug flags are specified in coupledFV3_MOM6_CICE_debug.appBuilder

2. Flags are used by NEMS MOM6 and CICE submodules to initiate debug makes
@MinsukJi-NOAA
Copy link
Collaborator Author

Attach build log with and without debug flags. Also attach regression test report.

build_w_debug.log
build_wo_debug.log
rtreport.txt

@DeniseWorthen
Copy link
Collaborator

We also need to update two files in conf for adding the -link_mpi=dbg to the FFLAGS_DEBUG settings for the configure.fv3_coupled.cheyenne.intel and configure.fv3_coupled.hera.intel. These have not yet been added to the develop branch but should be.

DeniseWorthen and others added 3 commits January 18, 2020 07:49
add -link_mpi=dbg to fflags_debug for cheyenne
add -link_mpi=dbg to fflags_debug for hera
added to correct conf files configure.fv3_coupled.MACHINE
@DeniseWorthen
Copy link
Collaborator

I've confirmed the top-level app build passes the flags down to MOM6 and CICE5. Once we merge the related PRs to the develop branches of CICE, MOM6-interface and NEMS, you'll need to amend you PR to point to NOAA_EMC repos (instead of your forks) and we can approve. Thanks!

Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@DeniseWorthen DeniseWorthen merged commit 7c5b4d9 into ufs-community:develop Jan 21, 2020
DeniseWorthen referenced this pull request in DeniseWorthen/ufs-s2s-model Jan 21, 2020
Add debug compilation flag specification at top level (#17)
@MinsukJi-NOAA MinsukJi-NOAA deleted the feature/s2s_debug_flag branch January 22, 2020 14:02
JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/ufs-s2s-model that referenced this pull request Feb 3, 2020
* Add debug compilation flag specification at top level

1. Debug flags are specified in coupledFV3_MOM6_CICE_debug.appBuilder

2. Flags are used by NEMS MOM6 and CICE submodules to initiate debug makes
JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/ufs-s2s-model that referenced this pull request Apr 23, 2020
ShanSunNOAA pushed a commit to ShanSunNOAA/ufs-s2s-model that referenced this pull request Oct 28, 2020
…l_update_and_aux_output_dom

Combine "Update to MYNN-EDMF" and "Output of auxiliary 2d/3d arrays from CCPP ufs-community#17"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants