Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update2020 01 #23

Merged
merged 5 commits into from
Jan 31, 2020
Merged

Update2020 01 #23

merged 5 commits into from
Jan 31, 2020

Conversation

binli2337
Copy link
Collaborator

The following two new compsets will be added to the ufs-s2s-model regression test system:

  1. FV3 using 2 threads
  2. FV3 using a different decomposition layout

The number of PETs used in each of the existing compsets will also be revised.

junwang-noaa
junwang-noaa approved these changes Jan 31, 2020
View reviewed changes
Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The threading test is just for atm, I assume this is an increment commit. In the future , the test will include threads for ocean and ice model too.

DeniseWorthen
DeniseWorthen approved these changes Jan 31, 2020
View reviewed changes
Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wrote in the commit summary that this included 'update FV3, MOM6 and NEMS'; there are no component updates so we should remove that from the summary if it does not apply.

@binli2337 binli2337 merged commit dd1bb0c into ufs-community:develop Jan 31, 2020
DeniseWorthen referenced this pull request in DeniseWorthen/ufs-s2s-model Feb 1, 2020
@DeniseWorthen
Merge pull request #13 from ufs-community/develop
56e42ca 
Update2020 01 (#23)
@binli2337 binli2337 deleted the update2020_01 branch February 3, 2020 10:53
JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/ufs-s2s-model that referenced this pull request Feb 3, 2020
@binli2337 @JessicaMeixner-NOAA
Update2020 01 (ufs-community#23)
a5d326d 
The following two new compsets will be added to the ufs-s2s-model regression test system:
1. FV3 using 2 threads
2. FV3 using a different decomposition layout

The number of PETs used in each of the existing compsets will also be revised.
Close ufs-community#22
ShanSunNOAA pushed a commit to ShanSunNOAA/ufs-s2s-model that referenced this pull request Oct 28, 2020
@DomHeinzeller
Merge pull request ufs-community#23 from climbfuji/gsd_develop_blocke…
7aa630e 
…d_data_structures

gsd/develop: handle blocked data structures in init and finalize routines, remove pset logic, metadata cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeniseWorthen DeniseWorthen DeniseWorthen approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binli2337 @junwang-noaa @DeniseWorthen