Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running of verification tasks from staged forecast output #565

Closed
gsketefian opened this issue Jan 30, 2023 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@gsketefian
Copy link
Collaborator

gsketefian commented Jan 30, 2023

Description

A common anticipated use of the SRW App is to run verification (both deterministic and ensemble) on staged forecast output generated by previous runs of the App. This capability needs to be added to the App.

Solution

Add one or more experiment configuration variables that enable this functionality (e.g. a variable that specifies the location of the staged forecast files) and modify scripts as needed to use these variables.

Requirements

Forecast files must be staged on the various platforms on which the SRW App is tested/run.

Acceptance Criteria

A WE2E test is added that can run verification (both deterministic and ensemble) on staged forecast output.

Dependencies

This issue is a prerequisite for resolving Issue #422.

@gsketefian gsketefian added the enhancement New feature or request label Jan 30, 2023
MichaelLueken pushed a commit that referenced this issue Feb 7, 2023
…ecast files (#566)

This PR enables running of only the SRW App's deterministic verification (vx) tasks on staged forecast files from previous runs of the App. It partially resolves Issue #565 (it resolves the issue for deterministic vx but not ensemble vx).

Specific changes:

* Update lua module file for vx tasks to suppress "Logging error" messages in vx task log files.
* Rename experiment variable MODEL to VX_FCST_MODEL_NAME to clarify that this is the name of the forecast model in the context of verification (and which will be used in the vx output files). This requires updates to most (all?) of the * METplus configuration files and the verification ex-scripts.
* Create the new variable VX_FCST_INPUT_BASEDIR to allow the user to specify a directory in which to look for staged forecast output (instead of running a forecast).
* Modify the rocoto template xml (FV3LAM_wflow.xml) to make dependencies of vx tasks on post-processing tasks appear only when the post tasks are enabled.
* Add a new WE2E test category subdirectory named verification in which to group all vx tests (since more vx tasks will be coming in future PRs). Move the two existing tests MET_verification and MET_ensemble_verification from wflow_features to verification, and add a new test named MET_verification_only_vxto test the capability that this PR introduces.
Note: The new WE2E test MET_verification_only_vx requires new data, specifically post-processed forecast output from the SRW App. This data needs to be staged on each platform; currently, it is located in a personal directory on Hera.
@mkavulich
Copy link
Collaborator

Resolved via #809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants