Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/AQM.v7] To define COMIN and COMOUT to support bias correction task #749

Closed
JianpingHuang-NOAA opened this issue Apr 27, 2023 · 3 comments · Fixed by #841
Closed
Assignees
Labels
enhancement New feature or request

Comments

@JianpingHuang-NOAA
Copy link

To support AQMv7 implementation, please define COMIN and COMOUT in J-job bias-correction scripts or job_preamble.sh for reading bias correction training data and saving bias correction data files for future BC use.

  1. Please using the following operational scripts for AQMv6 on WCOSS2 as a reference.

/lfs/h1/ops/prod/packages/aqm.v6.1.8/jobs
JAQM_POST_PM25_BICOR_CS
JAQM_POST_O3_BICOR_CS

  1. Please replace "AQM_AIRNOW_HIST_DIR" with COMINbir (for reading in or copying from) and COMOUTbir (for saving) for the scripts, exgional_bias_correction_o3.sh and exregional_bias_correction_pm25.sh at ~/scripts//scripts.
@JianpingHuang-NOAA JianpingHuang-NOAA added the enhancement New feature or request label Apr 27, 2023
@chan-hoo chan-hoo changed the title To define COMIN and COMOUT to support bias correction task [production/AQM.v7] To define COMIN and COMOUT to support bias correction task May 1, 2023
@chan-hoo
Copy link
Collaborator

chan-hoo commented May 1, 2023

@JianpingHuang-NOAA, 1) You can find the new COMIN/COMOUT defined in job_preamble.sh:

export COMIN="${COMIN:-$(compath.py -o ${NET}/${model_ver}/${RUN}.${PDY}/${cyc})}"

2) I think "AQM_AIRNOW_HIST_DIR" is totally different from "COMOUTbir". @KaiWang-NOAA, did you intend it?

@KaiWang-NOAA
Copy link

KaiWang-NOAA commented May 1, 2023 via email

@chan-hoo chan-hoo removed their assignment May 23, 2023
@chan-hoo
Copy link
Collaborator

chan-hoo commented Jun 8, 2023

@JianpingHuang-NOAA @KaiWang-NOAA, The PR for ecFlow (#821) has been merged. I didn't include @JianpingHuang-NOAA's change for COMINbicor in that PR because I was not familiar with it. I am sorry for that. Please submit a PR to address this issue separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants