Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need a workflow for data preproc tasks #781

Closed
christinaholtNOAA opened this issue May 8, 2023 · 1 comment
Closed

Need a workflow for data preproc tasks #781

christinaholtNOAA opened this issue May 8, 2023 · 1 comment
Assignees
@christinaholtNOAA

Comments

@christinaholtNOAA
Copy link
Collaborator

Adds the parm/wflow files to create an XML for running the first three data preprocessinging tasks.

These tasks will follow the naming conventions outlined in PR #633, and will be blocked by the three PRs for bufr, radar refl, and lightning task getting merged.
@christinaholtNOAA christinaholtNOAA self-assigned this May 8, 2023
michelleharrold pushed a commit to michelleharrold/ufs-srweather-app that referenced this issue Jun 7, 2023
@gsketefian
Bugfix: Pass domain name to python plotting scripts (ufs-community#783)
dca1617 
## DESCRIPTION OF CHANGES: 
PR #[763](ufs-community/regional_workflow#763) introduced the experiment variable `POST_OUTPUT_DOMAIN_NAME` and used it to modify the names of the UPP output files.  This PR adds `POST_OUTPUT_DOMAIN_NAME` as an argument to the python plotting scripts to enable those scripts to form the proper UPP output file names to read in.  It also modifies the batch scripts (`qsub_job.sh`, `qsub_job_diff.sh`, `sq_job.sh`, and `sq_job_diff.sh`) to add the new argument to the calls to the python plotting scripts that are called.

## TESTS CONDUCTED: 
Both python plotting scripts `plot_allvars.py` and `plot_allvars_diff.py` were run on Hera on preexisting UPP output files and completed successfully.  The batch scripts `sq_job.sh` and `sq_job_diff.sh` were also run successfully on Hera (`qsub_job.sh` and `qsub_job_diff.sh` were not run on e.g. Cheyenne).

## DEPENDENCIES:
PR # in `ufs-srweather-app`.

## DOCUMENTATION:
Modifications to the documentation are in PR #.

## ISSUE: 
Partially resolves issue ufs-community#781 (still need to introduce tests in `regional_workflow` that run the plotting scripts).

## CONTRIBUTORS: 
@mark-a-potts pointed out the problem and first made the necessary fixes in the `NOAA-EPIC` fork of `regional_workflow`; @gsketefian introduced those changes to this PR and made edits to the comments and documentation.
@mkavulich
Copy link
Collaborator

Resoved per RRFS Merge to SRW project board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christinaholtNOAA christinaholtNOAA

Labels
None yet
Projects
No open projects
RRFS Merge to SRW
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkavulich @christinaholtNOAA