Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix artifact creation for branches with / in name #275

Merged
merged 1 commit into from
May 25, 2022
Merged

Fix artifact creation for branches with / in name #275

merged 1 commit into from
May 25, 2022

Conversation

jessemcfarland
Copy link
Collaborator

DESCRIPTION OF CHANGES:

The slash in branch names such as release/.* and feature/.* is
interpreted as a directory separator. This change replaces the "/"
character with a "_".

TESTS CONDUCTED:

A successful Jenkins pipeline run.

@jessemcfarland jessemcfarland added the run_ci Launches CI/CD pipeline via jenkins label May 25, 2022
Fix artifact creation for branches with / in name
4bf237b 
The slash in branch names such as release/.* and feature/.* is
interpreted as a directory separator. This change replaces the "/"
character with a "_".
@jessemcfarland jessemcfarland removed the run_ci Launches CI/CD pipeline via jenkins label May 25, 2022
@jessemcfarland jessemcfarland added the run_ci Launches CI/CD pipeline via jenkins label May 25, 2022
@mark-a-potts mark-a-potts merged commit d0c0c69 into ufs-community:develop May 25, 2022
@jessemcfarland jessemcfarland deleted the bug/jenkins_branch_name branch May 25, 2022 19:24
natalie-perlin added a commit that referenced this pull request May 26, 2022
@natalie-perlin
Updated hpc-stack modules and compiler flags for building SRW release…
07516e7 
…/public-v2 on MacOS (#263)

* Updated versions of hpc-stack modules and compiler flags for building SRW release/public-v2

* Fix artifact creation for branches with / in name (#275)

The slash in branch names such as release/.* and feature/.* is
interpreted as a directory separator. This change replaces the "/"
character with a "_".

* Corrections to the modulefiles for the MacOS

Modulefiles load software libraries and activate python virtual environment

* correction in build_macos_gnu

* correction in build_macos_gnu

Co-authored-by: Natalie Perlin <Natalie@Natalies-MacBook-Air.local>
Co-authored-by: Jesse McFarland <jesse@mcfarland.sh>
Co-authored-by: Natalie Perlin <perlin.natalie@gmail.com>
mark-a-potts pushed a commit that referenced this pull request May 31, 2022
@BruceKropp-Raytheon
Update unified test script to run e2e tests (#284)
ede42b3 
* Fix artifact creation for branches with / in name (#275)

The slash in branch names such as release/.* and feature/.* is
interpreted as a directory separator. This change replaces the "/"
character with a "_".

* Update unified test script to run e2e tests

Execute the end-to-end test workflow during the test stage and archive
the test results.

Co-authored-by: Bruce Kropp <bruce.kropp@raytheon.com>
Co-authored-by: Jesse McFarland <jesse@mcfarland.sh>

Co-authored-by: Bruce Kropp <bruce.kropp@raytheon.com>
mark-a-potts pushed a commit that referenced this pull request Jun 1, 2022
@natalie-perlin
Release/public v2 jet bugfix (#286)
6a21e8f 
* Updated versions of hpc-stack modules and compiler flags for building SRW release/public-v2

* Fix artifact creation for branches with / in name (#275)

The slash in branch names such as release/.* and feature/.* is
interpreted as a directory separator. This change replaces the "/"
character with a "_".

* Corrections to the modulefiles for the MacOS

Modulefiles load software libraries and activate python virtual environment

* correction in build_macos_gnu

* correction in build_macos_gnu

* Update wflow_jet

Module load miniconda3 from /contrib/...
Prepend module path /contrib/miniconda3/modulefiles/ to the PATH (not _append_)

* Update wflow_jet

Adding a specific version of miniconda3/4.5.12 to be loaded, to avoid ambiguities with several available via /contrib/ and /hpc-stack/

Co-authored-by: Natalie Perlin <Natalie@Natalies-MacBook-Air.local>
Co-authored-by: Jesse McFarland <jesse@mcfarland.sh>
Co-authored-by: Natalie Perlin <perlin.natalie@gmail.com>
mark-a-potts added a commit that referenced this pull request Jun 12, 2022
@mark-a-potts @gspetro-NOAA
@gspetro @willmayfield @gsketefian @chan-hoo @danielabdi-noaa @natalie-perlin
updated version of ufs to include WoFS suite and ccpp-v6 (#293)
e024f4d 
* Fix artifact creation for branches with / in name (#275)

The slash in branch names such as release/.* and feature/.* is
interpreted as a directory separator. This change replaces the "/"
character with a "_".

* Include documentation for building/running SRW App on Mac (#240)

* updated docs

* added git submodule

* fix formatting

* added new submodule commits

* fixed ref links

* finished Intro

* finish Components & Intro edits

* edited Rocoto workflow section of Quickstart

* added minor hpc submodule commits

* Updates to Rocoto Workflow in Quick Start

* add to HPC-stack intro

* submodule updates

* added submodule docs edits

* hpc-stack updates & formatting fixes

* hpc-stack intro edits

* bibtex attempted fix

* add hpc-stack module edits

* update sphinxcontrib version

* add .readthedocs.yaml file

* update .readthedocs.yaml file

* update .readthedocs.yaml file

* update conf.py

* updates .readthedocs.yaml with submodules

* updates .readthedocs.yaml with submodules

* submodule updates

* submodule updates

* minor Intro edits

* minor Intro edits

* minor Intro edits

* submodule updates

* fixed typos in QS

* QS updates

* QS updates

* QS updates

* updates to InputOutput and QS

* fix I/O doc typos

* pull updates to hpc-stack docs

* pull updates to hpc-stack docs

* fix table wrapping

* updates to QS for cloud

* fix QS export statements

* fix QS export statements

* QS edits on bind, config

* add bullet points to notes

* running without rocoto

* add HPC-Stack submodule w/docs

* split QS into container/non-container approaches

* added filepath changes for running in container on Orion, et al.

* edits to overview and container QS

* moved CodeReposAndDirs.rst info to the Introduction & deleted file

* continued edits to SRWAppOverview

* combine overview w/non-container docs

* finish merging non-container guide & SRWOverview, rename/remove files, update FAQ

* minor edits for Intro & QS

* updates to BuildRun doc through 3.8.1

* edits to Build/Run and Components

* remove .gitignore

* fix Ch 3 title, 4 supported platform levels note

* fix typos, add term links

* other minor fixes/suggestions implemented

* updated Intro based on feedback; changed SRW to SRW App throughout

* update comment to Intro citation

* add user-defined vertical levels to future work

* Add instructions for srw_common module load

* fix typo

* update Intro & BuildRunSRW based on Mark's feedback

* minor intro updates

* 1st round of jwolff's edits

* 2nd round of jwolff updates

* update QS intro

* fix minor physics details

* update citation and physics suite name

* add compute node allocation info to QS

* add authoritative hpc-stack docs to Intro

* create MacOS install/build instructions

* add MacOS Build/Run instructions

* fix MacOS Build/Run details

* add MacOS info directly to Build/Run SRW chapter

* minor details

* minor edits

* update Include-HPCInstall with mac installation docs

* add note re: Terminal.app & bash shell in MacOS section

* remove MacInstall file-contents added to BuildRunSRW

* update hpc-stack submodule to include mac installation info

* add MacOS config details

* add MacOS config & run details

* minor MacOS note

* mention need to verify software library version #'s

* update hpc-stack-mod

* align MacDetails section with PR #238 info

* remove gsed & alter related commands

* update hpc-stack submodule

* typos

* switch from env to module load

Co-authored-by: Will Mayfield <59745143+willmayfield@users.noreply.github.com>

* Update BuildRunSRW.rst

* update hpc-stack module docs & MacOS config.sh

* update machine file instructions

* updates to BuildRun chapter

* fix typo

Co-authored-by: gspetro <gillian.s.petro@gmail.com>
Co-authored-by: Will Mayfield <59745143+willmayfield@users.noreply.github.com>

* Update documentation for CSV file containing WE2E test info (#278)

* Edits to documentation to match latest in code.

* Edits to documentation to match latest in code.

* Minor changes to documentation.

* Port SRW App to WCOSS2 (#270)

* port to wcoss2

* update scripts

* ensure platform name from variance

* update scripts

* remove wcoss2 from lmod-setup

* Fix --ccpp option in devbuild.sh (#280)

* fix ccpp issue

* update script

* Print usage if machine name is not passed to `lmod-setup.sh/csh`. (#262)

* Print usage() message if machine name is not passed.

* Bug fix with macos modulefiles.

* Back to original hashes (#287)

* Updated the Introduction, build for MacOS (#281)

* Updated the Introduction, build for MacOS

* Update Introduction.rst

Some comments removed

* Update Introduction.rst

Updated data storage requirements for the SRW

* Update documentation for python plotting scripts (#289)

## DESCRIPTION OF CHANGES: 
This PR updates the RST documentation files to accompany changes in PR #[783](ufs-community/regional_workflow#783) in `regional_workflow`.

## DEPENDENCIES:
PR #[783](ufs-community/regional_workflow#783) in `regional_workflow`.

## ISSUE (optional): 
Partially resolves issue #[781](ufs-community/regional_workflow#781) (still need to introduce tests in `regional_workflow` that run the plotting scripts).

## CONTRIBUTORS: 
@mark-a-potts

* Updating for testing with updated ufs weather model

* added version to wflow for jet

* switched to epic repo for testing

* Updates to modules for cheyenne

* updated module path

* changed hash to branch for testing

* updated to use ufs-community version of WM

* Pointing to PR-branch of regional_workflow for testing

* Updating module files for cheyenne for testing

* Added png explicitly under gaea.

* Update build_cheyenne_intel

Corrected loading system modules (load intel/2022.1, mpt/2.25), updated package versions if newer modules are built.

* Updated pointer to model for testing

* fixed repos

* updated to point at my regional_workflow branch

* updated regional_workflow to release/public-v2

Co-authored-by: Jesse McFarland <jesse@mcfarland.sh>
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
Co-authored-by: gspetro <gillian.s.petro@gmail.com>
Co-authored-by: Will Mayfield <59745143+willmayfield@users.noreply.github.com>
Co-authored-by: gsketefian <31046882+gsketefian@users.noreply.github.com>
Co-authored-by: Chan-Hoo.Jeon-NOAA <60152248+chan-hoo@users.noreply.github.com>
Co-authored-by: danielabdi-noaa <52012304+danielabdi-noaa@users.noreply.github.com>
Co-authored-by: Natalie Perlin <68030316+natalie-perlin@users.noreply.github.com>
Co-authored-by: Mark Potts <mpotts@redlineperf.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-a-potts mark-a-potts mark-a-potts approved these changes

@EdwardSnyder-NOAA EdwardSnyder-NOAA EdwardSnyder-NOAA approved these changes

@mkavulich mkavulich Awaiting requested review from mkavulich mkavulich is a code owner

@gsketefian gsketefian Awaiting requested review from gsketefian gsketefian is a code owner

@JeffBeck-NOAA JeffBeck-NOAA Awaiting requested review from JeffBeck-NOAA JeffBeck-NOAA is a code owner

@RatkoVasic-NOAA RatkoVasic-NOAA Awaiting requested review from RatkoVasic-NOAA RatkoVasic-NOAA is a code owner

@BenjaminBlake-NOAA BenjaminBlake-NOAA Awaiting requested review from BenjaminBlake-NOAA BenjaminBlake-NOAA is a code owner

@ywangwof ywangwof Awaiting requested review from ywangwof ywangwof is a code owner

@chan-hoo chan-hoo Awaiting requested review from chan-hoo chan-hoo is a code owner

@panll panll Awaiting requested review from panll panll is a code owner

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA is a code owner

@christopherwharrop-noaa christopherwharrop-noaa Awaiting requested review from christopherwharrop-noaa christopherwharrop-noaa is a code owner

@danielabdi-noaa danielabdi-noaa Awaiting requested review from danielabdi-noaa danielabdi-noaa is a code owner

@jkbk2004 jkbk2004 Awaiting requested review from jkbk2004 jkbk2004 is a code owner

@willmayfield willmayfield Awaiting requested review from willmayfield willmayfield is a code owner

@dmwright526 dmwright526 Awaiting requested review from dmwright526 dmwright526 is a code owner

@gspetro-NOAA gspetro-NOAA Awaiting requested review from gspetro-NOAA gspetro-NOAA is a code owner

@natalie-perlin natalie-perlin Awaiting requested review from natalie-perlin natalie-perlin is a code owner

Assignees
No one assigned
Labels
run_ci Launches CI/CD pipeline via jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessemcfarland @mark-a-potts @EdwardSnyder-NOAA