Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the Introduction, build for MacOS #281
Updated the Introduction, build for MacOS #281
Changes from 2 commits
99c2e4c
35d178f
5982034
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natalie-perlin Should we just list the software instead of the commands? The commands already appear in the instructions for installing HPC-Stack and in the MacOS-specific SRW instructions. At a minimum, I don't think we need the
brew upgrade bash
command because we're just listing what they should have on their system. The upgrade statement appears elsewhere in the docs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The important point here is that bash used to be included with the MacOS system until recently, when Apple stopped supporting and upgrading to a newer bash versions. The latest recent version of bash distributed with the macOS is
GNU bash, version 3.2.57(1)-release (arm64-apple-darwin20)
whereas at least bash v.4 is recommended.
So while it is present in MacOS, it cannot be simply upgraded using homebrew, because there is no previous
brew
installation of bash .Thus the comments about
brew install bash
andbrew upgrade bash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natalie-perlin Then the prerequisite we list should be bash v4.x. The logistics of installing it are in other places. If you prefer, I can make that change in my PR tho.