Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Update hashes of UFS_UTILS, ufs-weather-model, and UPP #354

Merged
merged 7 commits into from
Sep 20, 2022

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Sep 20, 2022

DESCRIPTION OF CHANGES:

  • Update the hashes of UFS_UTILS, ufs-weather-model, and UPP with the latest ones.
  • Update the module list.
  • Remove EMC_EXEC_DIR and add CMAKE_INSTALL_BINDIR for UFS_UTILS.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • WE2E tests:
    grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional
    grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
    grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
    grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km
    grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta
    community_ensemble_2mems_stoch

  • hera.intel

  • orion.intel

  • cheyenne.intel

  • cheyenne.gnu

  • gaea.intel

  • jet.intel

  • wcoss2.intel

  • NOAA Cloud (indicate which platform)

  • Jenkins

  • fundamental test suite

  • comprehensive tests (specify which if a subset was used)

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@chan-hoo chan-hoo added the run_ci Launches CI/CD pipeline via jenkins label Sep 20, 2022
@chan-hoo chan-hoo changed the title Update hashes of UFS_UTILS, ufs-weather-model, and UPP [develop] Update hashes of UFS_UTILS, ufs-weather-model, and UPP Sep 20, 2022
@chan-hoo chan-hoo added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Sep 20, 2022
Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@panll
Copy link
Collaborator

panll commented Sep 20, 2022

Looks good to me, too!

@chan-hoo chan-hoo removed the run_ci Launches CI/CD pipeline via jenkins label Sep 20, 2022
@chan-hoo chan-hoo added the run_ci Launches CI/CD pipeline via jenkins label Sep 20, 2022
@JeffBeck-NOAA
Copy link
Collaborator

JeffBeck-NOAA commented Sep 20, 2022

We really need this PR to automatically run all WE2E tests for a major update like this. @chan-hoo, do you mind running the ensemble_2mems_stoch WE2E test to make sure all stochastic physics are running as expected? Thanks, and also, many thanks for updating all these hashes!

@chan-hoo chan-hoo added run_we2e_comprehensive_tests Run the comprehensive set of SRW end-to-end tests and removed run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests labels Sep 20, 2022
@chan-hoo
Copy link
Collaborator Author

@JeffBeck-NOAA, the community_ensemble_2mems_stoch has been completed successfully. I have a question. If I add the label run_we2e_comprehensive_tests, will it run automatically somewhere else? I can't see anything for this.

@JeffBeck-NOAA
Copy link
Collaborator

@chan-hoo, thanks for running the stochastic physics WE2E test! I don't think the run_we2e_comprehensive_tests label is working quite yet, but once it will, it should kick off the Jenkins-based runs for all WE2E tests. @jessemcfarland is still working on the related PR.

@chan-hoo
Copy link
Collaborator Author

@JeffBeck-NOAA , I got it! If so, do you think this PR is ready for merged?

@chan-hoo chan-hoo removed the run_we2e_comprehensive_tests Run the comprehensive set of SRW end-to-end tests label Sep 20, 2022
@JeffBeck-NOAA
Copy link
Collaborator

@JeffBeck-NOAA , I got it! If so, do you think this PR is ready for merged?

@chan-hoo, all fundamental and CI-based tests passed, correct?

@chan-hoo
Copy link
Collaborator Author

@JeffBeck-NOAA, the WE2E tests listed in Description above and 'run_ci' test have been passed.

Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chan-hoo, I think we can go ahead and merge!

@danielabdi-noaa
Copy link
Collaborator

danielabdi-noaa commented Sep 20, 2022

@chan-hoo Thanks for the update! I suppose we can now build SRW app binaries in any directory other than exec and bin.
You may want to run the build to make sure that is the case though I expect it to work (i.e. binaries in mybin directory for example). If so, could you please modify devbuild.sh comment for --bin-dir accordingly? Thanks!

@chan-hoo chan-hoo merged commit b3eb96a into ufs-community:develop Sep 20, 2022
danielabdi-noaa pushed a commit to danielabdi-noaa/ufs-srweather-app that referenced this pull request Sep 21, 2022
…-community#354)

* update hashes and module list

* update docs

* update hash of ufs weather model

* remove emc_exec_dir

* back crtm to 2.3.0

* back g2tmpl to 1.10.0

* edit comment for bin-dir
@chan-hoo chan-hoo deleted the feature/hash_update branch September 21, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_ci Launches CI/CD pipeline via jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants