Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for Hera netcdf issue. #391

Merged

Conversation

danielabdi-noaa
Copy link
Collaborator

@danielabdi-noaa danielabdi-noaa commented Oct 3, 2022

DESCRIPTION OF CHANGES:

Bug fix for netcdf version issue on Hera. A recent update to hpc-stack updated netcdf version from 4.7.4 to 4.9.0. As a result the latter is loaded even though srw_common asks to load version 4.7.4 explicitly. This is because other libraries such as ncio and nccmp are built with 4.9.0 and they reload the netcdf version. This is a temporary fix that reorders the loading of these libraries to come before netcdf so that we will have 4.7.4 to build ufs-weather-model with instead of 4.9.0.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

#389

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

@MichaelLueken

@danielabdi-noaa danielabdi-noaa added bug Something isn't working Priority: HIGH ci-hera-intel-WE Kicks off automated workflow test on hera with intel labels Oct 3, 2022
@venitahagerty venitahagerty removed the ci-hera-intel-WE Kicks off automated workflow test on hera with intel label Oct 3, 2022
@danielabdi-noaa danielabdi-noaa added the ci-hera-intel-WE Kicks off automated workflow test on hera with intel label Oct 3, 2022
@venitahagerty venitahagerty removed the ci-hera-intel-WE Kicks off automated workflow test on hera with intel label Oct 3, 2022
@venitahagerty
Copy link
Collaborator

venitahagerty commented Oct 3, 2022

Machine: hera
Compiler: intel
Job: WE
Repo location: /scratch1/BMC/zrtrr/rrfs_ci/autoci/pr/1075231571/20221003233515/ufs-srweather-app
Build was Successful
Rocoto jobs started
Long term tracking will be done on 9 experiments
If test failed, please make changes and add the following label back:
ci-hera-intel-WE
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
Experiment Succeeded on hera: nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta
All experiments completed

@danielabdi-noaa danielabdi-noaa merged commit 045a02e into ufs-community:develop Oct 4, 2022
bluefinweiwei added a commit to bluefinweiwei/ufs-srweather-app that referenced this pull request Oct 12, 2022
Rename DTC-PAS to DTC-phytne
	modified:   modulefiles/build_hera_intel
	modified:   Externals.cfg
	modified:   modulefiles/srw_common
bluefinweiwei added a commit to bluefinweiwei/ufs-srweather-app that referenced this pull request Oct 12, 2022
Rename DTC-PAS to DTC-phytne

	modified:   Externals.cfg
	modified:   modulefiles/build_hera_intel
	modified:   modulefiles/srw_common
bluefinweiwei added a commit to bluefinweiwei/ufs-srweather-app that referenced this pull request Oct 12, 2022
Rename DTC-PAS to DTC-phytne

	modified:   Externals.cfg
	modified:   modulefiles/build_hera_intel
	modified:   modulefiles/srw_common
bluefinweiwei added a commit to DTC-phytne/ufs-srweather-app that referenced this pull request Oct 12, 2022
Rename DTC-PAS to DTC-phytne

	modified:   Externals.cfg
	modified:   modulefiles/build_hera_intel
	modified:   modulefiles/srw_common
bluefinweiwei added a commit to DTC-phytne/ufs-srweather-app that referenced this pull request Oct 13, 2022
* Temporary fix for Hera netcdf issue. (ufs-community#391)
Rename DTC-PAS to DTC-phytne

	modified:   Externals.cfg
	modified:   modulefiles/build_hera_intel
	modified:   modulefiles/srw_common

* Update repo url and branch for progsigma

	modified:   Externals.cfg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: HIGH
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants