Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Update Hera modulefiles to allow the SRW to build and run once again. #417

Conversation

MichaelLueken
Copy link
Collaborator

DESCRIPTION OF CHANGES:

The HPC-stack on Hera was updated at 17:05 today, October 13. This update caused the SRW to fail to build due to a new dependency on the nccmp module. This update will correct the issue and allow the SRW to once again build and run on Hera.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

Following the modifications, the SRW was successfully built on Hera and the fundamental WE2E tests were submitted. The tests are still running as of this time.

  • hera.intel - fundamental WE2E tests are still running at this time
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

…ow the SRW to build and run on Hera following update to HPC-stack.
Copy link
Collaborator

@danielabdi-noaa danielabdi-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelLueken I have made similar changes to jet and orion build modulefiles too thinking we would be encountering same issue as Hera. Now it looks like the opposite is happening, so you may want to move back nccmp to where they were before in jet/orion build modulefiles.

@MichaelLueken
Copy link
Collaborator Author

@MichaelLueken I have made similar changes to jet and orion build modulefiles too thinking we would be encountering same issue as Hera. Now it looks like the opposite is happening, so you may want to move back nccmp to where they were before in jet/orion build modulefiles.

Thanks, @danielabdi-noaa! I have updated modulefiles/build_jet_intel and modulefiles/build_orion_intel so that the nccmp module is loaded after NetCDF.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Oct 13, 2022
@MichaelLueken
Copy link
Collaborator Author

The hera.intel fundamental WE2E have successfully ran through to completion. Given @danielabdi-noaa approval, I have gone ahead and submitted the Jenkins CI testing for the machines.

@MichaelLueken
Copy link
Collaborator Author

All of the Jenkins CI pipeline tests have successfully passed. Require one more approval before this work can be merged to the official repository.

@MichaelLueken MichaelLueken merged commit b6a2843 into ufs-community:develop Oct 14, 2022
@MichaelLueken MichaelLueken deleted the feature/temp-hera-modulefile-fix branch October 14, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants