-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build script for developers, update Orion NCEPLIBS location #53
Add build script for developers, update Orion NCEPLIBS location #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why we need this extra build script on top of the ufs-weather-model build.sh
script, but ok (I wasn't part of the discussion in #45). You are now sourcing README files with ending .txt
as part of this build script. This is confusing. It's fine to do something like that, but we should rename those scripts from README_*.txt
to SOMETHINGMEANINGFUL_*.sh
in my opinion.
devbuild.sh
Outdated
|
||
usage () { | ||
echo "Usage: " | ||
echo " ./build.sh PLATFORM COMPILER" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this message say "./devbuild.sh ..." instead of "./build.sh ..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out. I have updated the script to use the builtin $0 variable instead (script name)
I think this is to build all the codes (not just ufs-weather-model) without having to cut-and-paste a bunch of stuff from README files. I'd agree that it would be clearer if the README_*.txt files were renamed to represent what they've really become (shell scripts), but I won't insist on it; I'll take what I can get! |
@climbfuji I know we have had this conversation several times now but we keep coming back to the same points. Some developers want a top-level build script so that we don't have to copy a dozen or so commands every time we build the full App, and I have trouble justifying the lack of one (aside from the desire to not support such a script to the community) so I am trying to reach a compromise. I will roughly copy my screed from the last PR:
Regarding the naming of the README files, I do not really have a strong opinion, but their main purpose is to be read and sourcing them is a secondary use. This script will only be used by a small number of internal developers. We could even remove it before the release if we are concerned about users trying to use it improperly. |
As I said, I don't have a problem with the build script being there, just wondering. But I bet that we'll get at least one user request about a failing build using it ;-) If your README files serve two purposes and are primarily used for copy & paste for the users of the SRW App release, then it's better to keep them as they are, agreed. If they are primarily used for the build script, then they should be renamed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
DESCRIPTION OF CHANGES:
Per discussion on #45, adding a build script for developer use. This will not be supported for community use, but limited to official platforms for testing purposes.
The build script should be invoked with the platform name and compiler as arguments, and works by sourcing the README files in the docs/ directory that describe the environment setup for each platform.
The README file for Orion also needed to be updated due to a change in the NCEPLIBS location to a more official spot.
TESTS CONDUCTED:
Built successfully on Cheyenne (gnu, intel) and Orion (intel). Should work for any platform with the appropriate README_[platform]_[compiler].txt file.