-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Enable run_post to work with varying forecast length hours #632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chan-hoo Overall, these changes look good to me! I have reached out to @natalie-perlin and she changed the defaults for netcdf
and hdf5
to 4.7.4
and 1.10.6
, rather than 4.9.1
and 1.14.0
, on Hera.
Please remove the additional lines in modulefiles/build_hera_intel.lua
and make sure that the AQM builds and runs. Once complete, I'll approve the change. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Thanks, @danielabdi-noaa |
@chan-hoo Please note that the Jenkins automated tests failed for Orion (same error as noted in issue #635). This is due to the old version of Git that is used by default on the machine. I'm manually running the fundamental WE2E tests on Orion now. Once they pass (or fail), I'll add that information to this PR. |
@MichaelLueken, thank you! |
@chan-hoo The WE2E fundamental tests were manually ran on Orion and all five tests successfully passed. Once the rest of the Jenkins tests complete, this work will be merged to develop. |
All tests successfully completed (with the exception of the tests on Orion). Since manual tests on Orion passed, I will now merge this PR into develop. |
DESCRIPTION OF CHANGES:
Type of change
TESTS CONDUCTED:
config.aqm.community.yaml on Hera and WCOSS2
config.aqm.nco.realtime.yaml on WCOSS2
hera.intel
orion.intel
cheyenne.intel
cheyenne.gnu
gaea.intel
jet.intel
wcoss2.intel
NOAA Cloud (indicate which platform)
Jenkins
fundamental test suite
comprehensive tests (specify which if a subset was used)
ISSUE:
Fixes issue mentioned in NOAA-EMC/AQM#63
CHECKLIST