Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Enable run_post to work with varying forecast length hours #632

Merged
merged 7 commits into from
Mar 6, 2023

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Mar 2, 2023

DESCRIPTION OF CHANGES:

  • Build UPP for AQM (Online-CMAQ).
  • Add four new cycles to the workflow XML file for real-time run with varying forecast length hours.
  • Update the UPP input namelist and control file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  1. WE2E tests:
  • community_ensemble_2mems_stoch
  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
  • MET_verification
  1. Sample script test for AQM
  • config.aqm.community.yaml on Hera and WCOSS2

  • config.aqm.nco.realtime.yaml on WCOSS2

  • hera.intel

  • orion.intel

  • cheyenne.intel

  • cheyenne.gnu

  • gaea.intel

  • jet.intel

  • wcoss2.intel

  • NOAA Cloud (indicate which platform)

  • Jenkins

  • fundamental test suite

  • comprehensive tests (specify which if a subset was used)

ISSUE:

Fixes issue mentioned in NOAA-EMC/AQM#63

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chan-hoo Overall, these changes look good to me! I have reached out to @natalie-perlin and she changed the defaults for netcdf and hdf5 to 4.7.4 and 1.10.6, rather than 4.9.1 and 1.14.0, on Hera.

Please remove the additional lines in modulefiles/build_hera_intel.lua and make sure that the AQM builds and runs. Once complete, I'll approve the change. Thanks!

modulefiles/build_hera_intel.lua Outdated Show resolved Hide resolved
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chan-hoo Thank you for removing the modification from modulefiles/build_hera_intel.lua! I will go ahead and approve the changes now. Please note that due to issue #635, I will hold off on submitting the Jenkins tests (also to allow for additional feedback from other reviewers).

Copy link
Collaborator

@danielabdi-noaa danielabdi-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@chan-hoo
Copy link
Collaborator Author

chan-hoo commented Mar 6, 2023

Thanks, @danielabdi-noaa

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Mar 6, 2023
@MichaelLueken
Copy link
Collaborator

@chan-hoo Please note that the Jenkins automated tests failed for Orion (same error as noted in issue #635). This is due to the old version of Git that is used by default on the machine. I'm manually running the fundamental WE2E tests on Orion now. Once they pass (or fail), I'll add that information to this PR.

@chan-hoo
Copy link
Collaborator Author

chan-hoo commented Mar 6, 2023

@MichaelLueken, thank you!

@MichaelLueken
Copy link
Collaborator

@chan-hoo The WE2E fundamental tests were manually ran on Orion and all five tests successfully passed. Once the rest of the Jenkins tests complete, this work will be merged to develop.

@MichaelLueken
Copy link
Collaborator

All tests successfully completed (with the exception of the tests on Orion). Since manual tests on Orion passed, I will now merge this PR into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants