-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop]: Add initial documentation for AQM #680
Conversation
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gspetro-NOAA Thank you very much for creating the initial documentation for AQM! This follows the wiki entry that @chan-hoo originally created here. Approving now.
@gspetro-NOAA, I really appreciate your work for AQM !!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gspetro-NOAA Thanks for giving me time to take a look, looks great!
@gspetro-NOAA Thanks for making the adjustments for WCOSS2! @chan-hoo If this looks good to you, I will go ahead and get this PR merged! |
@MichaelLueken, it looks good to me. Please go ahead. |
DESCRIPTION OF CHANGES:
This PR adds an AQM chapter to the
develop
branch documentation based on the information currently in our wiki.Type of change
TESTS CONDUCTED:
None required. Docs can be viewed on my fork's RTD account: https://srw-ug.readthedocs.io/en/text-aqm/AQM.html
I ran through the steps on Hera, and everything up to the actual experiment worked, but since I can't use
nems
on Hera, the workflow failed.DEPENDENCIES:
N/A
DOCUMENTATION:
All documentation.
ISSUE:
This partially resolves Issue #625 . More thorough documentation is needed, but this is a start.
CHECKLIST
CONTRIBUTORS (optional):
@chan-hoo